Human readable QR #678
Human readable QR #678
Conversation
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
This is the alignment, so paragraph left justified. Think center justifying it would then have multiple list items looking weird, so if that were the case think it would be centering just the paragraph (but then having to offset each list item so they line up)
|
Yeah, center-justifying is not the way to go. It looked like things "leaned" to the left like this, but if the box space being occupied is what is already being used then let's keep it as-is. |
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
|
Are we just adding a language array to the claims and not the title? |
I somehow missed that, good catch. We should add the same language mapping to the title - maybe we should have the language map as the root element with language and title both nested within it @Gavinok |
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
|
Added support for titles thanks for pointing that out. Should have just added that to begin with. |
| metadata={ | ||
| "title": {"en": "Get Name"}, | ||
| "claims": { | ||
| "en": [ | ||
| "That you are a BC Resident", | ||
| "That you are a member of the Law Society of British Columbia", | ||
| ] | ||
| }, | ||
| }, |
There was a problem hiding this comment.
What about using a single language key for each entry, rather than duplicating it?
| metadata={ | |
| "title": {"en": "Get Name"}, | |
| "claims": { | |
| "en": [ | |
| "That you are a BC Resident", | |
| "That you are a member of the Law Society of British Columbia", | |
| ] | |
| }, | |
| }, | |
| metadata={ | |
| "en":{ | |
| "title": "Get Name", | |
| "claims": [ | |
| "That you are a BC Resident", | |
| "That you are a member of the Law Society of British Columbia", | |
| ] | |
| } | |
| }, |
oidc-controller/api/routers/oidc.py
Outdated
| @@ -212,6 +212,20 @@ async def get_authorize(request: Request, db: Database = Depends(get_db)): | |||
| "controller_host": controller_host, | |||
| "challenge_poll_uri": ChallengePollUri, | |||
| "wallet_deep_link": wallet_deep_link, | |||
| "title": ( | |||
| ver_config.metadata.title.get("en") | |||
There was a problem hiding this comment.
It might be best to use a parameter for the language, so that we don;t have to update this condition when parsing a language dynamically
There was a problem hiding this comment.
Like a parameter for the function or for the template?
There was a problem hiding this comment.
I think what you did will work, once we have multilanguage support in the UI we just need to update the code to grab that value rathe rthan the hardcoded en that now only appears in one spot
…claims Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
This pr resolves #646
The key changes is the addition of the new metadata entry in the VerificationConfig that can contain the title of the verification and the claims it verifies. Here an example of the UI change on mobile.
and for desktop