clean up some smells

bcgov · Sep 18, 2023 · a67a12c · a67a12c
1 parent 9a8e807
commit a67a12c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/web/src/features/moreCast2/components/MoreCast2Column.tsx b/web/src/features/moreCast2/components/MoreCast2Column.tsx
@@ -95,15 +95,15 @@ export class IndeterminateField implements ColDefGenerator, ForecastColDefGenera
   }
 
   public generateForecastColDef = (headerName?: string) => {
-    return this.colDefBuilder.generateForecastColDef(headerName || this.headerName)
+    return this.colDefBuilder.generateForecastColDef(headerName ?? this.headerName)
   }
 
   public generateColDef = () => {
     return this.colDefBuilder.generateColDefWith(this.field, this.headerName, this.precision)
   }
 
   public generateColDefs = (headerName?: string) => {
-    return this.colDefBuilder.generateColDefs(headerName || this.headerName, this.includeBias)
+    return this.colDefBuilder.generateColDefs(headerName ?? this.headerName, this.includeBias)
   }
 }
 

diff --git a/web/src/features/moreCast2/slices/dataSlice.ts b/web/src/features/moreCast2/slices/dataSlice.ts
@@ -311,7 +311,7 @@ export const fillMissingWeatherIndeterminates = (
   const weatherIndeterminates: WeatherIndeterminate[] = [...items]
   for (const [key, values] of Object.entries(groupedByStationCode)) {
     const stationCode = parseInt(key)
-    const stationName = stationMap.get(stationCode) || ''
+    const stationName = stationMap.get(stationCode) ?? ''
     // We expect one actual per date in our date interval
     if (values.length < dateInterval.length) {
       for (const date of dateInterval) {
@@ -354,7 +354,7 @@ export const fillMissingPredictions = (
   const allPredictions = [...items]
   for (const [stationCodeAsString, weatherIndeterminatesByStationCode] of Object.entries(groupedByStationCode)) {
     const stationCode = parseInt(stationCodeAsString)
-    const stationName = stationMap.get(stationCode) || ''
+    const stationName = stationMap.get(stationCode) ?? ''
     const groupedByUtcTimestamp = createUtcTimeStampToWeatherIndeterminateGroups(
       weatherIndeterminatesByStationCode,
       dateInterval