Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ORJSONResponse class for determinates endpoint #3095

Merged
merged 12 commits into from
Sep 1, 2023
Merged

Conversation

dgboss
Copy link
Collaborator

@dgboss dgboss commented Aug 31, 2023

  • Use ORJSONResponse from orjson to serialize load from determinates endpoint
  • Fix npm version in our web containers. We were using @latest, but 10.0.0 was released Aug 31 and is not supported by the base image we're using or the next LTS.

Test Links:

Landing Page
MoreCast 2.0
Percentile Calculator
MoreCast
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #3095 (8135b2e) into main (3049b09) will decrease coverage by 0.06%.
Report is 1 commits behind head on main.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main    #3095      +/-   ##
==========================================
- Coverage   84.78%   84.73%   -0.06%     
==========================================
  Files         300      300              
  Lines       10094    10118      +24     
  Branches      591      591              
==========================================
+ Hits         8558     8573      +15     
- Misses       1374     1383       +9     
  Partials      162      162              
Files Changed Coverage Δ
api/app/weather_models/process_grib.py 62.75% <0.00%> (-0.65%) ⬇️
api/app/jobs/common_model_fetchers.py 80.23% <76.19%> (-3.10%) ⬇️
api/app/db/models/weather_models.py 98.03% <100.00%> (+0.03%) ⬆️
api/app/routers/morecast_v2.py 89.10% <100.00%> (+0.10%) ⬆️
api/app/weather_models/fetch/predictions.py 77.77% <100.00%> (ø)
api/app/wildfire_one/schema_parsers.py 94.66% <100.00%> (+0.30%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@conbrad conbrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as a quick fix, we may want to consider also updating our models to have these fields as optional so we show these as N/A on the frontend

@sonarcloud
Copy link

sonarcloud bot commented Aug 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dgboss dgboss temporarily deployed to production September 1, 2023 15:28 Inactive
@dgboss dgboss changed the title Show 0 for actuals with None value Use ORJSONResponse class for determinates endpoint Sep 1, 2023
@dgboss dgboss merged commit 9a3ed28 into main Sep 1, 2023
31 checks passed
@dgboss dgboss deleted the bug/fix-actuals-none branch September 1, 2023 16:15
vanislekahuna pushed a commit to vanislekahuna/wps that referenced this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants