Wind speed and wind speed informed variables use cffdrs #3123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3123 +/- ##
==========================================
- Coverage 84.72% 84.71% -0.02%
==========================================
Files 300 301 +1
Lines 10110 10123 +13
Branches 588 588
==========================================
+ Hits 8566 8576 +10
- Misses 1381 1384 +3
Partials 163 163
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
conbrad
changed the title
conbrad
commented
Sep 22, 2023
| @@ -52,6 +52,8 @@ def mock_wfwx_stations(): | |||
| station_2 = WFWXWeatherStation(latitude=1, longitude=1, elevation=1, | |||
| wfwx_id='ba28973a-0a79-04ea-e053-1d09228e8c65', code=2, | |||
| name='blah', zone_code='T1') | |||
| loop = asyncio.new_event_loop() | |||
There was a problem hiding this comment.
The test that exercises this started complaining there was no event loop (only on CI!) when constructing the Future below, so it's explicitly created now.
brettedw
approved these changes
Sep 25, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cffdrsnow, instead of optionally using wf1 values if they existmath.isclosewith a0.001absolute tolerance: https://docs.python.org/3/library/math.html?highlight=isclose#math.isclosepytest-bddwhich is not being actively updated and has a parser bugTest Links:
Landing Page
MoreCast 2.0
Percentile Calculator
MoreCast
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator