Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASA Map Legend #3147

Merged
merged 25 commits into from
Oct 5, 2023
Merged

ASA Map Legend #3147

merged 25 commits into from
Oct 5, 2023

Conversation

brettedw
Copy link
Collaborator

@brettedw brettedw commented Oct 5, 2023 •
edited by github-actions bot
Loading

  • Adds ASA Map Legend with layer control
  • Adds 'close' button to Summary Panel
  • Changes zoom and panning of fire zones when a zone is selected
  • Adds tests for ASA Legend

Test Links:

Landing Page
MoreCast 2.0
Percentile Calculator
MoreCast
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

@brettedw
initial legend commit
b751be7
@brettedw
adds state mgmt and subItems
59715ff
@brettedw
adds symbols to legend
5d6ecd4
@brettedw
adds legend title
24fb783
@brettedw
adjust alignment
3bebf98
@brettedw
bold title
8c8485e
@brettedw
manage state better, FBAMap -> Legend
d947a9b
@brettedw
css cleanup
633cfae
@brettedw
disable flaky morecast 1 test
8a8288e
@brettedw
bring back hfi dependency
5ad0511
@brettedw
dedupe some code
0ab7741
@brettedw
Remove unused hfi layer defs, replaced by pmtiles
d0bacc8
@brettedw
fixes fire zone not selectable if not color filled
c76bde9
@brettedw
adds functioning summary panel close button
6549c64
@brettedw
add props to fbaMap.test
807f1de
@brettedw
adds map panning changes on click
bed6255
@brettedw
Makes scroll bar permanent
a9da430 
It will always be there anyway and removes stutter on zone change click
@brettedw
legend font/margin changes
d64c50e
@brettedw
legend item padding changes
70e51b1
@brettedw
change legend title
d73b13b
@brettedw
adds legend tests
19d54d4
@brettedw
better testid names
f3ba526
@brettedw
Merge branch 'main' into task/asa-map-legend
6e60332
@brettedw
add tests
5eb7bd9
@brettedw brettedw changed the title Task/asa map legend ASA Map Legend Oct 5, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023 •
edited
Loading

Codecov Report

Merging #3147 (130cb40) into main (4d5e3b6) will decrease coverage by 0.47%.
Report is 3 commits behind head on main.
The diff coverage is 55.12%.

@@            Coverage Diff             @@
##             main    #3147      +/-   ##
==========================================
- Coverage   84.71%   84.25%   -0.47%     
==========================================
  Files         301      301              
  Lines       10123    10113      -10     
  Branches      588      588              
==========================================
- Hits         8576     8521      -55     
- Misses       1384     1429      +45     
  Partials      163      163
Files Coverage Δ
api/app/db/models/weather_models.py 97.36% <100.00%> (-0.68%) ⬇️
api/app/weather_models/machine_learning.py 89.83% <100.00%> (-2.97%) ⬇️
.../features/fireWeather/components/maps/constants.ts 100.00% <ø> (ø)
api/app/weather_models/__init__.py 93.65% <77.77%> (-3.32%) ⬇️
api/app/jobs/common_model_fetchers.py 58.13% <34.78%> (-22.76%) ⬇️
api/app/weather_models/process_grib.py 62.10% <40.00%> (-0.65%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Oct 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@brettedw brettedw requested a review from conbrad October 5, 2023 18:14
conbrad
conbrad approved these changes Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@conbrad conbrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@brettedw brettedw temporarily deployed to production October 5, 2023 18:39 Inactive
@brettedw brettedw merged commit 7df71d8 into main Oct 5, 2023
29 checks passed
@brettedw brettedw deleted the task/asa-map-legend branch October 5, 2023 18:51
vanislekahuna pushed a commit to vanislekahuna/wps that referenced this pull request Sep 19, 2024
@brettedw
ASA Map Legend (bcgov#3147)
a29071d 
- Adds ASA Map Legend with layer control
- Adds 'close' button to Summary Panel
- Changes zoom and panning of fire zones when a zone is selected
- Adds tests for ASA Legend
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conbrad conbrad conbrad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brettedw @conbrad