Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables bias adjusted wind direction #3149

Merged
merged 20 commits into from
Oct 16, 2023
Merged

Conversation

conbrad
Copy link
Collaborator

@conbrad conbrad commented Oct 6, 2023

  • Enables bias adjusted wind direction through a different path for machine learning via RegressionModelsV2
    • this maintains a collection of regression models for each weather parameter
  • Defines an interface for models that expects add_sample, train and predict methods for implementations
  • Implements just wind direction for this new pattern, all other models are using old code path in machine_learning.py
  • Pulls out Samples class into it's own module
  • Enables displaying of wind direction bias column in frontend

Test Links:

Landing Page
MoreCast 2.0
Percentile Calculator
MoreCast
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #3149 (1500f63) into main (3f96d74) will increase coverage by 0.06%.
Report is 1 commits behind head on main.
The diff coverage is 87.71%.

@@            Coverage Diff             @@
##             main    #3149      +/-   ##
==========================================
+ Coverage   81.98%   82.05%   +0.06%     
==========================================
  Files         265      267       +2     
  Lines        9050     9131      +81     
  Branches      413      413              
==========================================
+ Hits         7420     7492      +72     
- Misses       1517     1526       +9     
  Partials      113      113              
Files Coverage Δ
api/app/weather_models/__init__.py 96.82% <100.00%> (+3.17%) ⬆️
api/app/weather_models/fetch/predictions.py 77.77% <ø> (ø)
api/app/weather_models/sample.py 100.00% <100.00%> (ø)
.../features/moreCast2/components/MoreCast2Column.tsx 93.47% <100.00%> (ø)
api/app/jobs/common_model_fetchers.py 58.13% <50.00%> (ø)
api/app/weather_models/machine_learning.py 86.53% <73.33%> (-3.30%) ⬇️
api/app/weather_models/regression_model.py 87.50% <87.50%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@conbrad conbrad changed the title Bias adjusted wind direction Enables bias adjusted wind direction Oct 16, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@conbrad conbrad temporarily deployed to production October 16, 2023 21:55 Inactive
@conbrad conbrad merged commit 22ed18a into main Oct 16, 2023
27 checks passed
@conbrad conbrad deleted the story/bias-adjusted-wind-direction branch October 16, 2023 22:07
vanislekahuna pushed a commit to vanislekahuna/wps that referenced this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants