Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decommission MoreCast 1 #3155

Merged
merged 14 commits into from
Oct 11, 2023
Merged

Decommission MoreCast 1 #3155

merged 14 commits into from
Oct 11, 2023

Conversation

brettedw
Copy link
Collaborator

@brettedw brettedw commented Oct 10, 2023 •
edited by github-actions bot
Loading

  • Removes all unused code from MoreCast (except maps)
  • Moves code that's still needed for other applications

Test Links:

Landing Page
MoreCast 2.0
Percentile Calculator
MoreCast
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

@codecov
Copy link

codecov bot commented Oct 10, 2023 •
edited
Loading

Codecov Report

Merging #3155 (e8fc4ff) into main (1013ff7) will decrease coverage by 2.27%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3155      +/-   ##
==========================================
- Coverage   84.25%   81.98%   -2.27%     
==========================================
  Files         301      265      -36     
  Lines       10113     9050    -1063     
  Branches      588      413     -175     
==========================================
- Hits         8521     7420    -1101     
- Misses       1429     1517      +88     
+ Partials      163      113      -50
Files Coverage Δ
web/src/app/Routes.tsx 90.90% <ø> (-0.76%) ⬇️
web/src/app/rootReducer.ts 100.00% <ø> (ø)
web/src/features/NoMatchPage.tsx 100.00% <ø> (ø)
web/src/features/landingPage/toolInfo.tsx 0.00% <ø> (ø)
web/src/utils/constants.ts 100.00% <ø> (ø)

... and 16 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@brettedw brettedw requested review from conbrad and dgboss October 10, 2023 23:32
conbrad
conbrad reviewed Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@conbrad conbrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, just a couple of small things

web/src/app/Routes.tsx Outdated Show resolved Hide resolved
web/src/features/fireWeather/components/graphs/plotlyHelper.ts Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Oct 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@socket-security
Copy link

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: plotly.js@2.26.2, react-plotly.js@2.6.0

@brettedw brettedw temporarily deployed to production October 11, 2023 18:51 Inactive
@brettedw brettedw merged commit 3f96d74 into main Oct 11, 2023
30 checks passed
@brettedw brettedw deleted the task/decommission-morecast branch October 11, 2023 19:04
vanislekahuna pushed a commit to vanislekahuna/wps that referenced this pull request Sep 19, 2024
@brettedw
Decommission MoreCast 1 (bcgov#3155)
74eb99f 
- Removes all unused code from MoreCast (except maps)
- Reroutes MoreCast to MoreCast 2.0
- Moves code that's still needed for other applications in the repo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgboss dgboss dgboss approved these changes

@conbrad conbrad conbrad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brettedw @conbrad @dgboss