MoreCast 2.0 - Simulated Indices #3200

brettedw · 2023-10-30T22:11:23Z

Adds endpoint for calculating FWI indices
Calculates FWI indices in real time while forecasting
Calculates all FWI indices on load, for actuals and forecasts

Dependencies

Linked Issues

fixes MoreCast 2.0: Implement Simulated Indices #3140

- adds lat/long to Morecast rows - updates API for simulating indices

- updates end point for simulating indices

- stores edited rows in redux store - maps stored rows to new rows on user edit

- use single function for fwi calculations - calculate ALL fwi values where possible

codecov · 2023-10-31T20:01:14Z

Codecov Report

Merging #3200 (5afe044) into main (81d37b2) will decrease coverage by 0.18%.
The diff coverage is 75.11%.

@@            Coverage Diff             @@
##             main    #3200      +/-   ##
==========================================
- Coverage   82.05%   81.88%   -0.18%     
==========================================
  Files         274      275       +1     
  Lines        9301     9489     +188     
  Branches      413      445      +32     
==========================================
+ Hits         7632     7770     +138     
- Misses       1557     1604      +47     
- Partials      112      115       +3

Files	Coverage Δ
api/app/morecast_v2/forecasts.py	`93.68% <100.00%> (+3.85%)`	⬆️
api/app/routers/morecast_v2.py	`90.26% <100.00%> (+1.15%)`	⬆️
api/app/schemas/morecast_v2.py	`100.00% <100.00%> (ø)`
api/app/wildfire_one/schema_parsers.py	`94.96% <100.00%> (+0.06%)`	⬆️
.../features/moreCast2/components/MoreCast2Column.tsx	`93.47% <100.00%> (ø)`
web/src/features/moreCast2/saveForecasts.ts	`64.70% <ø> (-3.72%)`	⬇️
.../features/moreCast2/components/DataGridColumns.tsx	`89.65% <0.00%> (ø)`
...res/moreCast2/components/GridComponentRenderer.tsx	`86.66% <75.00%> (-1.97%)`	⬇️
web/src/features/moreCast2/rowFilters.ts	`95.65% <95.65%> (ø)`
web/src/features/moreCast2/util.ts	`95.55% <94.73%> (-0.60%)`	⬇️
... and 6 more

... and 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

…sk/simulated-indices

web/src/features/moreCast2/components/ForecastSummaryDataGrid.tsx

api/app/routers/morecast_v2.py

api/app/morecast_v2/forecasts.py

api/app/schemas/morecast_v2.py

conbrad

Looking good, almost there I think. Remember to update your branch off main as well.

web/src/features/moreCast2/components/TabbedDataGrid.tsx

web/src/features/moreCast2/rowFilters.ts

dgboss

Strong work!

I think this is really close to being wrapped up!

web/src/features/moreCast2/rowFilters.ts

web/src/features/moreCast2/components/TabbedDataGrid.tsx

web/src/features/moreCast2/interfaces.ts

web/src/features/moreCast2/slices/dataSlice.ts

api/app/morecast_v2/forecasts.py

conbrad · 2023-11-09T00:13:47Z

web/src/features/moreCast2/rowFilters.test.ts

Nice tests!

sonarcloud · 2023-11-09T02:58:26Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

- Adds endpoint for calculating FWI indices - Calculates FWI indices in real time while forecasting - Calculates all FWI indices on load, for actuals and forecasts

brettedw and others added 18 commits October 17, 2023 10:24

adds more fwi functions from R library

a37074f

adds lat/long to WeatherIndeterminate

d6faa20

calculate forecasted fwi system values

95af97e

adds FWI actuals/forecasts to Forecast Summary tab

ba327f0

Morecast 2.0 frontend

e17027e

- adds lat/long to Morecast rows - updates API for simulating indices

Morecast 2.0 backend

784ab60

- updates end point for simulating indices

updates api and updates forecasts in redux store

a4bd266

updates tests

264b8ff

docstring

9b58a8f

Merge branch 'main' into task/simulated-indices

233e84a

forecast choice labels

e1b5dca

- stores edited rows in redux store - maps stored rows to new rows on user edit

moves api call to func, adds success/fail slice

19c7057

backend

8670144

- use single function for fwi calculations - calculate ALL fwi values where possible

Get extra day of determinates for fwi calc

abae508

Merge branch 'main' into task/simulated-indices

bbde898

Fix router test, handle empty dates

0684687

Merge branch 'main' into task/simulated-indices

a6cd4e6

Merge branch 'main' into task/simulated-indices

bfeb943

brettedw and others added 10 commits October 31, 2023 14:50

add backend tests for get_fwi_values

12892bc

code smell

649ae55

Add dataslice tests

7657c36

Merge branch 'task/simulated-indices' of github.com:bcgov/wps into ta…

4fc612c

…sk/simulated-indices

endpoint tests

f6006cc

unused imports

f071f13

processRowUpdate bug squasher?

d20bef9

smelly code

cf624cd

Merge branch 'main' into task/simulated-indices

057d039

Merge branch 'main' into task/simulated-indices

8c1667a

conbrad reviewed Nov 2, 2023

View reviewed changes

web/src/features/moreCast2/components/ForecastSummaryDataGrid.tsx Outdated Show resolved Hide resolved

brettedw added 8 commits November 6, 2023 14:30

adds util tests

01dc387

adds row filtering tests

400adaa

Merge branch 'main' into task/simulated-indices

3d410f1

row filter tests and rowFilters.ts

e9ec48d

update rowFilters test

1b57b96

Merge branch 'main' into task/simulated-indices

b4759bc

rowFilters test refinement

776db25

typos

708aecd

brettedw requested a review from conbrad November 7, 2023 18:23

dgboss reviewed Nov 7, 2023

View reviewed changes

api/app/routers/morecast_v2.py Show resolved Hide resolved

dgboss reviewed Nov 7, 2023

View reviewed changes

api/app/morecast_v2/forecasts.py Show resolved Hide resolved

dgboss reviewed Nov 7, 2023

View reviewed changes

api/app/schemas/morecast_v2.py Outdated Show resolved Hide resolved

conbrad reviewed Nov 7, 2023

View reviewed changes

web/src/features/moreCast2/components/TabbedDataGrid.tsx Outdated Show resolved Hide resolved

web/src/features/moreCast2/rowFilters.ts Outdated Show resolved Hide resolved

camel to snake

a4fa721

dgboss requested changes Nov 8, 2023

View reviewed changes

brettedw added 5 commits November 8, 2023 10:09

add tests for mapForecastChoiceLabels

983e4bf

address some comments

3c937f5

address more comments

59dc6f4

Merge branch 'main' into task/simulated-indices

f1472a4

add tests for rowFilters returning undefined

862f276

brettedw requested review from conbrad and dgboss November 8, 2023 20:51

conbrad approved these changes Nov 9, 2023

View reviewed changes

web/src/features/moreCast2/rowFilters.test.ts Outdated

Copy link

Collaborator

conbrad Nov 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tests!

NicolasLivanos reacted with heart emoji

Merge branch 'main' into task/simulated-indices

5afe044

dgboss approved these changes Nov 9, 2023

View reviewed changes

brettedw temporarily deployed to production November 9, 2023 23:05 Inactive

conbrad merged commit ae101df into main Nov 9, 2023
32 checks passed

conbrad deleted the task/simulated-indices branch November 9, 2023 23:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MoreCast 2.0 - Simulated Indices #3200

MoreCast 2.0 - Simulated Indices #3200

brettedw commented Oct 30, 2023 •

edited by conbrad

Loading

codecov bot commented Oct 31, 2023 •

edited

Loading

conbrad left a comment •

edited

Loading

dgboss left a comment

conbrad Nov 9, 2023

sonarcloud bot commented Nov 9, 2023

MoreCast 2.0 - Simulated Indices #3200

MoreCast 2.0 - Simulated Indices #3200

Conversation

brettedw commented Oct 30, 2023 • edited by conbrad Loading

Test Links:

Dependencies

Linked Issues

codecov bot commented Oct 31, 2023 • edited Loading

Codecov Report

conbrad left a comment • edited Loading

Choose a reason for hiding this comment

dgboss left a comment

Choose a reason for hiding this comment

conbrad Nov 9, 2023

Choose a reason for hiding this comment

sonarcloud bot commented Nov 9, 2023

brettedw commented Oct 30, 2023 •

edited by conbrad

Loading

codecov bot commented Oct 31, 2023 •

edited

Loading

conbrad left a comment •

edited

Loading