Task/zone units frontend #3204
Task/zone units frontend #3204
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3204 +/- ##
=======================================
Coverage 82.05% 82.05%
=======================================
Files 274 274
Lines 9301 9301
Branches 413 413
=======================================
Hits 7632 7632
Misses 1557 1557
Partials 112 112
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Nice work! It looks great to me. Just one minor suggestion if you haven't already done it, consider checking in with Neal regarding the label choice for the zone unit polygons on the map. We're showing things like 'V8-North Island Mid Coast Fire Zone' as a label which seems a little awkward to me.
Oh, and there is one code smell.
|
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Looks great! Agreed with Darren on the label question for Neal.
One other labelling question I have is the label names between the lower mainland Fraser area and the Haida Gwaii area. I see they're separated advisory wise which is awesome, but wondering if Neal may want them labelled in a different way somehow. Maybe not since those names are probably technically correct
| """compute zone unit combustible area | ||
|
|
||
| Revision ID: d5115b761e39 | ||
| Revises: 5b745fe0bd7a |
There was a problem hiding this comment.
| Revises: 5b745fe0bd7a | |
| Revises: f2e027a47a3f |
- Generalizes the concept of `FireZone` to `FireShape` throughout the codebase - Adds migration for adding fire zone unit shape type - Adds migration for calculating fire zone unit combustible area - Points frontend layers to the fire zone unit pmtiles files
FireZonetoFireShapethroughout the codebaseTest Links:
Landing Page
MoreCast 2.0
Percentile Calculator
MoreCast
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator