Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASA: Fix fire zone unit name lookup, adjust zone -> shape naming #3207

Merged
merged 1 commit into from
Nov 1, 2023
Merged

ASA: Fix fire zone unit name lookup, adjust zone -> shape naming #3207

merged 1 commit into from
Nov 1, 2023

Conversation

conbrad
Copy link
Collaborator

@conbrad conbrad commented Nov 1, 2023 •
edited by github-actions bot
Loading

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@conbrad conbrad requested a review from brettedw November 1, 2023 22:12
@codecov Codecov
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #3207 (af6615a) into main (38ec422) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3207   +/-   ##
=======================================
  Coverage   82.05%   82.05%           
=======================================
  Files         274      274           
  Lines        9301     9301           
  Branches      413      413           
=======================================
  Hits         7632     7632           
  Misses       1557     1557           
  Partials      112      112

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@conbrad conbrad temporarily deployed to production November 1, 2023 23:16 Inactive
@conbrad conbrad merged commit 60becdb into main Nov 1, 2023
31 checks passed
@conbrad conbrad deleted the bug/fire-shape-name-lookup branch November 1, 2023 23:28
vanislekahuna pushed a commit to vanislekahuna/wps that referenced this pull request Sep 19, 2024
@conbrad
ASA: Fix fire zone unit name lookup, adjust zone -> shape naming (bcg…
01a970b 
…ov#3207)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgboss dgboss dgboss approved these changes

@brettedw brettedw Awaiting requested review from brettedw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@conbrad @dgboss