Subtract dates not datetimes

[dgboss]

The bug manifested because of the time change. When subtracting datetime objects to get a timedelta, you get an extra day if your dates span a time change. Switching to subtracting dates avoids this problem.

Test Links:

Landing Page
MoreCast 2.0
Percentile Calculator
MoreCast
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

[codecov]

Codecov Report

Merging #3219 (c8d1304) into main (41334be) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3219      +/-   ##
==========================================
+ Coverage   82.05%   82.08%   +0.03%     
==========================================
  Files         274      274              
  Lines        9301     9301              
  Branches      413      413              
==========================================
+ Hits         7632     7635       +3     
+ Misses       1557     1556       -1     
+ Partials      112      110       -2     

Files	Coverage Δ
api/app/utils/time.py	88.88% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

[conbrad]

When subtracting datetime objects to get a timedelta, you get an extra day if your dates span a time change

Think it'd be worth added a test for this case? 2 datetimes, one pst, one pdt, fails before your change, passes after your change?

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[dgboss]

When subtracting datetime objects to get a timedelta, you get an extra day if your dates span a time change

Think it'd be worth added a test for this case? 2 datetimes, one pst, one pdt, fails before your change, passes after your change?

Ha, started on the tests before I saw this! Did one for the time change in both directions.