Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASA: Color coded fuel types #3220

Merged
merged 5 commits into from
Nov 7, 2023
Merged

ASA: Color coded fuel types #3220

merged 5 commits into from
Nov 7, 2023

Conversation

dgboss
Copy link
Collaborator

@dgboss dgboss commented Nov 7, 2023

  • Update colours of pie slices representing fuel types to match BCWS standards
  • Move labels outside of pie slices
  • Add label lines

Adding a picture to demonstrate what it looks like as there is no data in the PR deployment (and you don't already have prod data for Sept 1 - 7 locally).
image

Test Links:

Landing Page
MoreCast 2.0
Percentile Calculator
MoreCast
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #3220 (d88ce97) into main (d1d8460) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3220   +/-   ##
=======================================
  Coverage   82.05%   82.05%           
=======================================
  Files         274      274           
  Lines        9301     9301           
  Branches      413      413           
=======================================
  Hits         7632     7632           
  Misses       1557     1557           
  Partials      112      112           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@dgboss dgboss requested review from conbrad and brettedw November 7, 2023 20:10
Copy link
Collaborator

@conbrad conbrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

web/src/features/fba/components/viz/FuelTypesBreakdown.tsx Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dgboss dgboss temporarily deployed to production November 7, 2023 21:16 Inactive
@dgboss dgboss merged commit 7bf6ef1 into main Nov 7, 2023
30 checks passed
@dgboss dgboss deleted the task/color-coded-fuel/2603 branch November 7, 2023 21:38
vanislekahuna pushed a commit to vanislekahuna/wps that referenced this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants