Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MoreCast overflow #3324

Merged
merged 4 commits into from
Jan 18, 2024
Merged

MoreCast overflow #3324

merged 4 commits into from
Jan 18, 2024

Conversation

brettedw
Copy link
Collaborator

@brettedw brettedw commented Jan 17, 2024

Changes overflow/scroll to only effect data within the DataGrid

resolves #3322

Test Links:

Landing Page
MoreCast 2.0
Percentile Calculator
MoreCast
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2f426c7) 81.85% compared to head (e6cb368) 81.85%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3324   +/-   ##
=======================================
  Coverage   81.85%   81.85%           
=======================================
  Files         277      277           
  Lines        9563     9563           
  Branches      450      450           
=======================================
  Hits         7828     7828           
  Misses       1616     1616           
  Partials      119      119           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brettedw brettedw requested a review from dgboss January 17, 2024 23:09
@brettedw brettedw changed the title MoreCast Overflow MoreCast overflow Jan 17, 2024
Copy link

sonarcloud bot commented Jan 18, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@brettedw brettedw temporarily deployed to production January 18, 2024 21:13 Inactive
@brettedw brettedw merged commit 7631acd into main Jan 18, 2024
31 checks passed
@brettedw brettedw deleted the task/morecast-ui-overflow branch January 18, 2024 21:21
vanislekahuna pushed a commit to vanislekahuna/wps that referenced this pull request Sep 19, 2024
Changes overflow/scroll to only effect data within the DataGrid
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MoreCast: Header and left-right scrolling
3 participants