Implementation and tests for TPI stats endpoints #3838
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3838 +/- ##
==========================================
+ Coverage 79.31% 79.47% +0.15%
==========================================
Files 295 295
Lines 10874 10887 +13
Branches 518 518
==========================================
+ Hits 8625 8652 +27
+ Misses 2105 2091 -14
Partials 144 144 ☔ View full report in Codecov by Sentry. |
api/app/routers/fba.py
Outdated
| stats = await get_zonal_tpi_stats(session, fire_zone_id, run_type, run_datetime, for_date) | ||
| return FireZoneTPIStats( | ||
| fire_zone_id=fire_zone_id, | ||
| valley_bottom=stats.valley_bottom * stats.pixel_size_metres, |
There was a problem hiding this comment.
Is pixel size stored as area? Or a 1-D length? If the latter, then we might want to square the pixel size.
There was a problem hiding this comment.
Ultimately it might not matter as we're just displaying percentages in the frontend, not absolute values.
There was a problem hiding this comment.
You're right it's 1-D length, I'll square it. Otherwise it may be confusing in the future / if another consumer uses the endpoint.
|
- Adds TPI stats endpoint that returns the (assumed) single record for TPI stats for a specific run time and run parameters
- Since TPI stats are counts of cells that hit HFI > 4k for each classification, this is returned as an area, count * pixel size in metres
- Adds tests for authenticated and unauthenticated endpoint calls
- Removes unnecessary mock JWT with roles in test suite
- Adds TPI stats endpoint that returns the (assumed) single record for TPI stats for a specific run time and run parameters
- Since TPI stats are counts of cells that hit HFI > 4k for each classification, this is returned as an area, count * pixel size in metres
- Adds tests for authenticated and unauthenticated endpoint calls
- Removes unnecessary mock JWT with roles in test suite
Test Links:
Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator