Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/geospatial tests #3841

Merged
merged 5 commits into from
Aug 13, 2024
Merged

Task/geospatial tests #3841

merged 5 commits into from
Aug 13, 2024

Conversation

conbrad
Copy link
Collaborator

@conbrad conbrad commented Aug 13, 2024

@conbrad conbrad requested review from dgboss and brettedw August 13, 2024 18:08
api/app/utils/geospatial.py Outdated Show resolved Hide resolved
tpi_ds = None


@pytest.mark.skip(reason="enable once gdal is updated past version 3.4")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious why we have to wait?

Copy link
Collaborator Author

@conbrad conbrad Aug 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works locally with a newer GDAL, fails with API image in the CI/CD pipeline

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 4 lines in your changes missing coverage. Please review.

Project coverage is 79.76%. Comparing base (ea10ff8) to head (1b7affd).

Files Patch % Lines
api/app/utils/geospatial.py 77.77% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3841      +/-   ##
==========================================
+ Coverage   79.47%   79.76%   +0.29%     
==========================================
  Files         295      295              
  Lines       10887    10885       -2     
  Branches      518      518              
==========================================
+ Hits         8652     8682      +30     
+ Misses       2091     2059      -32     
  Partials      144      144              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: dgboss <darren.boss@gov.bc.ca>
Copy link

sonarcloud bot commented Aug 13, 2024

Copy link
Collaborator

@brettedw brettedw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@conbrad conbrad temporarily deployed to production August 13, 2024 18:58 Inactive
@conbrad conbrad merged commit db4a4e0 into main Aug 13, 2024
24 checks passed
@conbrad conbrad deleted the task/geospatial-tests branch August 13, 2024 19:13
dgboss pushed a commit that referenced this pull request Aug 14, 2024
Co-authored-by: dgboss <darren.boss@gov.bc.ca>
Test suite for geospatial functions introduced in #3800
vanislekahuna pushed a commit to vanislekahuna/wps that referenced this pull request Sep 19, 2024
Co-authored-by: dgboss <darren.boss@gov.bc.ca>
Test suite for geospatial functions introduced in bcgov#3800
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests for api/app/utils/geospatial.py
3 participants