Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fire Center Advisory Report #3850

Merged
merged 27 commits into from
Aug 15, 2024
Merged

Fire Center Advisory Report #3850

merged 27 commits into from
Aug 15, 2024

Conversation

brettedw
Copy link
Collaborator

@brettedw brettedw commented Aug 14, 2024 •
edited
Loading

brettedw added 25 commits August 2, 2024 17:07
@brettedw
init
94f6583
@brettedw
fix ASA not going full width & menu bar overlap
a1897ef
@brettedw
simplify map/sidePanel sizing
eca15fc
@brettedw
simplify layout further
2ed58a5
@brettedw
remove import
a02f5b9
@brettedw
remove combustible area viz
ad89cb4
@brettedw
advisory report text auto generate
b77b644
@brettedw
colours and status logic
1c2bd77
@brettedw
zoneStatus use var
8aafa8c
@brettedw
Refactor text
8733fbf
@brettedw
remove dropdown date metadata
29194bd
@brettedw
text date change
a5f393a
@brettedw
Merge branch 'main' into task/auto-advisory-report
f487086
@brettedw
Merge branch 'main' into task/auto-advisory-report
f553444
@brettedw
Merge branch 'main' into task/auto-advisory-report
514aaca
@brettedw
fire center advisories, zooming
1ec8f27
@brettedw
imports, remove showSummaryPanel
ecda5bc
@brettedw
fbaMap test
9c48b3c
@brettedw
Merge branch 'main' into task/auto-advisory-report
12d2e63
@brettedw
BC & initial extent
486b6ef
@brettedw
report tab state names
9486ee6
@brettedw
make smell happy
cc2a1b5
@brettedw
text change
d725d7b
@brettedw
tests
b25369d
@brettedw
more tests
da8cf59
@brettedw brettedw requested review from dgboss and conbrad August 14, 2024 17:07
@brettedw brettedw closed this Aug 14, 2024
@brettedw brettedw reopened this Aug 14, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.74%. Comparing base (6fcdc94) to head (4945b35).
Report is 1 commits behind head on main.

Files Patch % Lines
web/src/components/FireCenterDropdown.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3850      +/-   ##
==========================================
- Coverage   79.76%   79.74%   -0.02%     
==========================================
  Files         295      295              
  Lines       10885    10888       +3     
  Branches      518      518              
==========================================
+ Hits         8682     8683       +1     
- Misses       2059     2061       +2     
  Partials      144      144

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

conbrad
conbrad approved these changes Aug 14, 2024
View reviewed changes
Copy link
Collaborator

@conbrad conbrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🚀 🚀 🚀

dgboss
dgboss approved these changes Aug 14, 2024
View reviewed changes
Copy link
Collaborator

@dgboss dgboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Nice work!

@conbrad conbrad temporarily deployed to production August 15, 2024 17:15 Inactive
@conbrad conbrad merged commit 490df2a into main Aug 15, 2024
28 checks passed
@conbrad conbrad deleted the task/auto-advisory-report branch August 15, 2024 17:31
conbrad pushed a commit that referenced this pull request Aug 19, 2024
@brettedw @conbrad
Fire Center Advisory Report (#3850)
4e651ee 
- Advisory bulletins by fire center
- Fixes zoom to province extent
conbrad pushed a commit that referenced this pull request Aug 19, 2024
@brettedw @conbrad
Fire Center Advisory Report (#3850)
5797062 
- Advisory bulletins by fire center
- Fixes zoom to province extent
conbrad pushed a commit that referenced this pull request Aug 19, 2024
@brettedw @conbrad
Fire Center Advisory Report (#3850)
bbf19e9 
- Advisory bulletins by fire center
- Fixes zoom to province extent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgboss dgboss dgboss approved these changes

@conbrad conbrad conbrad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ASA: Fire Center Auto-generated Advisory
3 participants
@brettedw @conbrad @dgboss