TPI Frontend #3862
TPI Frontend #3862
Conversation
- Advisory bulletins by fire center - Fixes zoom to province extent
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
- Use wildcard for ignoring all `.env` files in any directory - Remove unused example env keys - Add missing example env keys
Changes actual/forecast dropdown to radio buttons
- Advisory bulletins by fire center - Fixes zoom to province extent
- Advisory bulletins by fire center - Fixes zoom to province extent
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3862 +/- ##
=======================================
Coverage 79.74% 79.75%
=======================================
Files 295 295
Lines 10888 10889 +1
Branches 518 518
=======================================
+ Hits 8683 8684 +1
Misses 2061 2061
Partials 144 144 ☔ View full report in Codecov by Sentry. |
| AdvisoryTPIStats.valley_bottom, | ||
| AdvisoryTPIStats.mid_slope, | ||
| AdvisoryTPIStats.upper_slope, | ||
| AdvisoryTPIStats.advisory_shape_id, AdvisoryTPIStats.valley_bottom, AdvisoryTPIStats.mid_slope, AdvisoryTPIStats.upper_slope, AdvisoryTPIStats.pixel_size_metres |
There was a problem hiding this comment.
Is pixel_size needed here?
There was a problem hiding this comment.
Yeah it's expected to compute the area in the TPI endpoint
| @@ -8,7 +8,7 @@ interface InfoPanelProps { | |||
| // A component to host information in a side panel in ASA. | |||
| const InfoPanel = React.forwardRef(({ children }: InfoPanelProps, ref: React.ForwardedRef<HTMLDivElement>) => { | |||
| return ( | |||
| <Grid data-testid="info-panel" item ref={ref} sx={{ width: '500px', overflowY: 'auto' }}> | |||
| <Grid data-testid="info-panel" item ref={ref} sx={{ minWidth: '500px', maxWidth: '500px', overflowY: 'auto' }}> | |||
There was a problem hiding this comment.
Just curious, what's the purpose of setting both min and max width to be equal?
There was a problem hiding this comment.
No idea, picked it up from the existing commits in the branch but I can try undoing it 😅
|
Closes #2190
Test Links:
Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator