Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes NaN classified TPI percentages because we were dividing by zero. #3868

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

conbrad
Copy link
Collaborator

@conbrad conbrad commented Aug 21, 2024

Push down logic to ElevationStatus and add regression test for the issue.

Closes #3863

@conbrad conbrad changed the title Push down logic to ElevationStatus and add regression test Fixes NaN classified TPI percentages because we were dividing by zero. Aug 21, 2024
@conbrad conbrad requested a review from brettedw August 21, 2024 18:43
Copy link

sonarcloud bot commented Aug 21, 2024

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.73%. Comparing base (08636f7) to head (592cb0b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3868   +/-   ##
=======================================
  Coverage   79.73%   79.73%           
=======================================
  Files         295      295           
  Lines       10891    10891           
  Branches      519      519           
=======================================
  Hits         8684     8684           
  Misses       2063     2063           
  Partials      144      144           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@conbrad conbrad temporarily deployed to production August 21, 2024 19:05 Inactive
@conbrad conbrad merged commit 4be25e9 into main Aug 21, 2024
28 checks passed
@conbrad conbrad deleted the task/NaN-tpi-bug-fix branch August 21, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ASA: TPI breakdown percentages show NaN
2 participants