Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper fire zone unit label #3902

Merged
merged 3 commits into from
Sep 5, 2024
Merged

Proper fire zone unit label #3902

merged 3 commits into from
Sep 5, 2024

Conversation

dgboss
Copy link
Collaborator

@dgboss dgboss commented Sep 5, 2024

  • Include geographic place name in label on the map on.
  • Wrap the place name to a second line to prevent labels from being too long.
    Example:
    R8 - Skeena Zone
    (Kalum)

Test Links:

Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.70%. Comparing base (d2ee27f) to head (f33023f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3902   +/-   ##
=======================================
  Coverage   79.70%   79.70%           
=======================================
  Files         293      293           
  Lines       10863    10863           
  Branches      517      517           
=======================================
  Hits         8658     8658           
  Misses       2063     2063           
  Partials      142      142           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Sep 5, 2024

@dgboss dgboss requested review from conbrad and brettedw September 5, 2024 18:27
@dgboss dgboss temporarily deployed to production September 5, 2024 18:43 Inactive
@dgboss dgboss merged commit 30f0c07 into main Sep 5, 2024
28 checks passed
@dgboss dgboss deleted the task/zone-unit-label/3888 branch September 5, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants