Add fuel types and critical hours to advisory

[dgboss]

• advisory bulletin only displays info for selected fire zone unit
• bulletin includes up to top 3 fuel types
• critical hours start time is the earliest start time from the top three fuel types
• critical hours end time is the latest end time from the three top fuel types
• closes ASA: Add Fuel Information to Advisory Bulletin #3879

Test Links:

Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.31%. Comparing base (fac4b2f) to head (26fbecd).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3918   +/-   ##
=======================================
  Coverage   81.31%   81.31%           
=======================================
  Files         294      294           
  Lines       11362    11362           
  Branches      526      526           
=======================================
  Hits         9239     9239           
  Misses       2089     2089           
  Partials       34       34           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[brettedw]

Looking awesome, learned a few things. Only thing I noticed was that if there is fuel stats but no critical hours for some reason the text reads something like:

There is a fire behaviour Advisory in effect for N2-Invermere Fire Zone between null:00 and null:00 for fuel types M-1/M-2, C-3 and C-7.

[dgboss]

Looking awesome, learned a few things. Only thing I noticed was that if there is fuel stats but no critical hours for some reason the text reads something like:

There is a fire behaviour Advisory in effect for N2-Invermere Fire Zone between null:00 and null:00 for fuel types M-1/M-2, C-3 and C-7.

Huh? It's not supposed to do that! I'll re-visit the logic. Might be a null check versus an undefined check thing. Thanks!

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[dgboss]

Looking awesome, learned a few things. Only thing I noticed was that if there is fuel stats but no critical hours for some reason the text reads something like:

There is a fire behaviour Advisory in effect for N2-Invermere Fire Zone between null:00 and null:00 for fuel types M-1/M-2, C-3 and C-7.

Huh? It's not supposed to do that! I'll re-visit the logic. Might be a null check versus an undefined check thing. Thanks!

Yep, was a null vs. undefined check. Fixed in 26fbecd