refactor OwnableExecutor module & fixed tests #580
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VGabriel45
changed the title
size-limit report 📦
|
VGabriel45
requested review from
joepegler and
livingrockrises
and removed request for
joepegler
joepegler
approved these changes
Sep 19, 2024
| // buildUseropDto | ||
| ) | ||
| } | ||
| // async sendTransactionWithExecutor( |
| accountAddress?: Address | ||
| ): Promise<UserOpReceipt> { | ||
| senderSmartAccount?: NexusSmartAccount | ||
| ): Promise<Partial<UserOperationStruct>> { |
There was a problem hiding this comment.
Was thinking about this after you mentioned it yesterday. Taking inspiration and being consistent with the other decorators that deal with sending user ops here. see clients/decorators/installModule, clients/decorators/uninstallFallback etc. They allow you to pass in options for sending the userop (gas estimates etc), and return the user op hash.
| @@ -193,4 +185,15 @@ export class OwnableExecutorModule extends BaseExecutionModule { | |||
|
|
|||
| return owners as Address[] | |||
| } | |||
|
|
|||
| public async isModuleInitialized(smartAccount?: Address): Promise<any> { | |||
There was a problem hiding this comment.
Looks like another useful decorator
| @@ -198,7 +252,7 @@ export const toConfiguredAnvil = async ({ | |||
| rpcPort | |||
| }: { rpcPort: number }): Promise<AnvilInstance> => { | |||
| const instance = anvil({ | |||
| hardfork: "Paris", | |||
| hardfork: "Cancun", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR updates code related to smart account deployment and testing utilities.
Detailed summary
publicClient.getBytecodetopublicClient.getCodein multiple files.type NexusSmartAccountandtype UserOperationStruct.BaseExecutionModulemethod signature.createSmartAccountClientwithgetTestSmartAccountin test files.BaseSmartContractAccountimplementation.getTestSmartAccountfunction for testing smart accounts.hardforkvalue from "Paris" to "Cancun".testClient.getBytecodewithtestClient.getCodein test files.byteCodeDeployerfunction to usepublicClient.getCode.createOwnableExecutorModulefunction and related changes in test files.