feat: generalized url chain id regex check #586
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved regex check for chain id in bundler and paymaster url to fit other url structure's as well.
PR-Codex overview
This PR focuses on enhancing the
extractChainIdFromUrl
function inUtils.ts
by improving error handling and adding documentation. It also introduces unit tests for various URL structures to ensure correct chain ID extraction.Detailed summary
extractChainIdFromUrl
, detailing parameters, return values, and error handling.extractChainIdFromBundlerUrl
andextractChainIdFromPaymasterUrl
functions, both utilizingextractChainIdFromUrl
.read.test.ts
to validate chain ID extraction from multiple URL formats.