🔒 H-02 - Prevent Freezing of Funds in Factory Contracts #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aboudjem
requested review from
filmakarov,
ankurdubey521,
VGabriel45 and
livingrockrises
Changes to gas cost
🧾 Summary (5% most significant diffs)
Full diff report 👇
|
Aboudjem
changed the title
| @@ -58,6 +58,8 @@ contract NexusAccountFactory is Stakeable, INexusFactory { | |||
| if (!alreadyDeployed) { | |||
| INexus(account).initializeAccount(initData); | |||
| emit AccountCreated(account, initData, salt); | |||
| } else if (msg.value > 0) { | |||
| revert AccountAlreadyDeployed(account); | |||
There was a problem hiding this comment.
can we have negative test case for this how entrypoint behaves.
There was a problem hiding this comment.
by sending a userop
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## fix/security-h01 #114 +/- ##
====================================================
- Coverage 72.18% 71.17% -1.02%
====================================================
Files 13 13
Lines 676 680 +4
Branches 124 151 +27
====================================================
- Hits 488 484 -4
- Misses 186 196 +10
+ Partials 2 0 -2
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Aboudjem
changed the title
🔒 H-03 - Enforce Registry Calls Before Module Setup to Comply with EIP-7484
🤖 Slither Analysis Report 🔎Slither report
# Slither report
_This comment was automatically generated by the GitHub Actions workflow._
THIS CHECKLIST IS NOT COMPLETE. Use
constable-statesImpact: Optimization
|
🔒 H-02 - Prevent Freezing of Funds in Factory Contracts
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
livingrockrises
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
H-02. Freezing of user funds in factory contracts when
alreadyDeployedistrueIssue: When a user tries to create a Nexus account that has already been deployed, the initial ETH deposit gets stuck in the factory contract. This can be exploited by attackers to perform griefing attacks.
Fix: Introduced a new error
AccountAlreadyDeployedthat reverts the tx if the account is already deployed andmsg.value> 0.Summary of Fixes:
AccountAlreadyDeployederror.AccountAlreadyDeployedwhen the account is already deployed andmsg.value> 0.