🔒 L-01 & L-02 - Prevent Data Loss in Events and Allow Overriding of entryPoint() Function

[Aboudjem]

L-01. The indexed Keyword in Events Causes Data Loss for Variables of type bytes

• Issue: indexed keyword causes data loss for bytes variables in events.
• Affected Events: AccountCreated in NexusAccountFactory.
• Fix: Remove indexed keyword from bytes variables in events.

---

L-02. entryPoint() function cannot be overridden

• Issue: entryPoint() function lacks the virtual keyword.
• Affected Functions: entryPoint.
• Fix: Add virtual keyword to entryPoint() function.

---

[github-actions]

Changes to gas cost

Generated at commit: 9db9023dd8e88c220707cb1b7bcbadaee29f2af9, compared to commit: 78aa8682ea447be76d0f4c376c7988044da4a3e4

🧾 Summary (5% most significant diffs)

Contract	Method	Avg (+/-)	%
NexusAccountFactory	createAccount	+5,167 ❌	+2.25%

---

Full diff report 👇

Contract	Deployment Cost (+/-)	Method	Min (+/-)	%	Avg (+/-)	%	Median (+/-)	%	Max (+/-)	%	# Calls (+/-)
NexusAccountFactory	813,115 (-3,444)	createAccount	217,510 (+5,167)	+2.43%	235,131 (+5,167)	+2.25%	237,650 (+5,167)	+2.22%	237,650 (+5,167)	+2.22%	8 (0)

[github-actions]

🤖 Slither Analysis Report 🔎

Slither report

# Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary

• constable-states (2 results) (Optimization)

constable-states

Impact: Optimization
🔴 Confidence: High

• ID-0
  RegistryAdapter.registry should be constant

base/RegistryAdapter.sol#L12

• ID-1
  RegistryFactory.threshold should be constant

factory/RegistryFactory.sol#L39

_This comment was automatically generated by the GitHub Actions workflow._

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.73%. Comparing base (78aa868) to head (d742909).

Additional details and impacted files

@@                Coverage Diff                @@
##           fix/security-m06     #123   +/-   ##
=================================================
  Coverage             71.73%   71.73%           
=================================================
  Files                    13       13           
  Lines                   697      697           
  Branches                157      133   -24     
=================================================
  Hits                    500      500           
  Misses                  197      197           

Files	Coverage Δ
contracts/base/BaseAccount.sol	62.85% <100.00%> (ø)

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78aa868...d742909. Read the comment docs.

[livingrockrises]

why did we remove indexed here?

[Aboudjem]

Removed indexed because it hashes bytes data, making it unretrievable from logs. Without indexed, the actual initData can be emitted and accessed as intended

[Aboudjem]

check L-01 for more info