Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/cantina fixes #139

Merged
merged 31 commits into from
Aug 19, 2024
Merged

Fix/cantina fixes #139

merged 31 commits into from
Aug 19, 2024

Commits on Aug 15, 2024

  1. #26 Remove unnecessary module type check in uninstallModule function

    @Aboudjem
    Aboudjem committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    c7b3d0f View commit details
    Browse the repository at this point in the history

  2. #25 Update K1Validator to use isValidSignatureNowCalldata method for … 

    …signature validation
    @Aboudjem
    Aboudjem committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    6f86af4 View commit details
    Browse the repository at this point in the history

  3. #24 Update RegistryFactory constructor to validate threshold against … 

    …attesters length
    @Aboudjem
    Aboudjem committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    0747d3d View commit details
    Browse the repository at this point in the history

  4. chore: Update RegistryFactory constructor to validate threshold again… 

    …st attesters length
    @Aboudjem
    Aboudjem committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    7d2cbb7 View commit details
    Browse the repository at this point in the history

  5. #15: Fix validator check and revert error in Nexus initialization

    @Aboudjem
    Aboudjem committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    7f237b8 View commit details
    Browse the repository at this point in the history

  6. remove empty line

    @Aboudjem
    Aboudjem committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    07162ce View commit details
    Browse the repository at this point in the history

  7. #14 refactor _uninstallValidator (gas optimization)

    @Aboudjem
    Aboudjem committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    b8fe78c View commit details
    Browse the repository at this point in the history

  8. #10 Typos & Documentation errors and updates

    @Aboudjem
    Aboudjem committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    e1ddd0e View commit details
    Browse the repository at this point in the history

  9. #15 Update Nexus initialization to include validator check

    @Aboudjem
    Aboudjem committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    6a54eb4 View commit details
    Browse the repository at this point in the history

  10. refactor: introduce _hasValidators validator check

    @Aboudjem
    Aboudjem committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    d199ff4 View commit details
    Browse the repository at this point in the history

  11. refactor: update error CannotRemoveLastValidator -> MissingValidator … 

    …to be more generic in IModuleManagerEventsAndErrors.sol
    @Aboudjem
    Aboudjem committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    aacd37d View commit details
    Browse the repository at this point in the history

  12. #7: Update ModuleType from uint256 to uint8

    @Aboudjem
    Aboudjem committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    2115a82 View commit details
    Browse the repository at this point in the history

  13. refactor: Add test for reverting account initialization without valid… 

    …ator
    @Aboudjem
    Aboudjem committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    39bc78b View commit details
    Browse the repository at this point in the history

  14. refactor: Update RegistryFactory constructor to validate threshold ag… 

    …ainst attesters length
    @Aboudjem
    Aboudjem committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    95dfc94 View commit details
    Browse the repository at this point in the history

  15. refactor: Update error message from CannotRemoveLastValidator to Miss… 

    …ingValidator for more generic handling
    @Aboudjem
    Aboudjem committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    970d808 View commit details
    Browse the repository at this point in the history

  16. refactor: Update error message from CannotRemoveLastValidator to Miss… 

    …ingValidator for more generic handling
    @Aboudjem
    Aboudjem committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    8b0b6d2 View commit details
    Browse the repository at this point in the history

  17. refactor: Update error message from CannotRemoveLastValidator to Miss… 

    …ingValidator for more generic handling
    @Aboudjem
    Aboudjem committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    db5a697 View commit details
    Browse the repository at this point in the history

  18. refactor: Update error message from CannotRemoveLastValidator to Miss… 

    …ingValidator for more generic handling
    @Aboudjem
    Aboudjem committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    a47720b View commit details
    Browse the repository at this point in the history

  19. #9: Update NonceLib to use byte function instead of shifting and mask… 

    …ing for vmode calculation
    @Aboudjem
    Aboudjem committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    fe2df72 View commit details
    Browse the repository at this point in the history

  20. #4 Missing return parameters in natspec

    @Aboudjem
    Aboudjem committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    ea3c7e2 View commit details
    Browse the repository at this point in the history

  21. #5: Add factoryOwner check in K1ValidatorFactory constructor + test

    @Aboudjem
    Aboudjem committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    f8fa433 View commit details
    Browse the repository at this point in the history

  22. #40 add memory-safe assembly annotation

    @Aboudjem
    Aboudjem committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    94a0afc View commit details
    Browse the repository at this point in the history

  23. #11 add natspec for parsenablemodedata

    @Aboudjem
    Aboudjem committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    dbe28dd View commit details
    Browse the repository at this point in the history

  24. #3 Document that RegistryFactory.createAccount is only compatible wit… 

    …h an inner Bootstrap.initNexus
    @Aboudjem
    Aboudjem committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    884b652 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2024

  1. refactor: Improve natspec for validateUserop

    @Aboudjem
    Aboudjem committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    84f0948 View commit details
    Browse the repository at this point in the history

  2. refactor: Update error for removing last validator

    @Aboudjem
    Aboudjem committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    d8696cc View commit details
    Browse the repository at this point in the history

  3. refactor: Update error for removing last validator

    @Aboudjem
    Aboudjem committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    0a12d75 View commit details
    Browse the repository at this point in the history

  4. refactor: Update error for removing last validator

    @Aboudjem
    Aboudjem committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    a2730fc View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2024

  1. Merge branch 'remediations/cantina-spearbit' into fix/cantina-fixes

    @Aboudjem
    Aboudjem authored Aug 18, 2024
    Configuration menu
    Copy the full SHA
    1ec9599 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. Merge branch 'remediations/cantina-spearbit' into fix/cantina-fixes

    @Aboudjem
    Aboudjem authored Aug 19, 2024
    Configuration menu
    Copy the full SHA
    b1f51b2 View commit details
    Browse the repository at this point in the history

  2. respond to PR comments

    @livingrockrises
    livingrockrises committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    fb1e85b View commit details
    Browse the repository at this point in the history