Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improving Github Actions code #845

Closed
wants to merge 1 commit into from

Conversation

michelboaventura
Copy link

  • Properly formatting
  • master -> main
  • Update ubuntu from 20.04 to latest
  • Update actions to newest version
  • Running lints and generation with elixir 1.17 and otp 27
  • Replace deprecated ::set-output with env vars

I didn't add elixir 1.17 to the test matrix because I'd have to remove 1.14 since 1.17 isn't compatible with OTP 24which is required for 1.14. If we decide to drop 1.14 support we could do it.

@michelboaventura michelboaventura requested a review from a team as a code owner July 5, 2024 19:20
@doomspork
Copy link
Member

Thank you @michelboaventura 🙏 However, going forward we are planning to manage these from a common repository, Common Config, as we've done with ExMachina and others: .github/workflows/common-config.yaml. My plan is to start that process this weekend so

I'm going to close this but welcome you taking a look at our Common Config repo and seeing whether there are opportunities there to improve our actions. Alternatively, if you'd like to kick off the CC work on this repo feel free to do so, an example can be found here

@doomspork doomspork closed this Jul 5, 2024
@michelboaventura
Copy link
Author

Sure thing! I was hoping that with this PR the action that generates new lib versions would start working again so we could solve this issue too! I think it makes total sense to have a common config since there are so many projects within beam-community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants