Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the output expected from Fava on startup #57

Merged
merged 1 commit into from
Sep 8, 2024

Conversation

dgchurchill
Copy link
Contributor

Fava outputs "Starting Fava on ..." instead of "Running Fava on ..." since this commit.

Also, if the Fava process was already running, beancount-fava would just kill it. Now it will kill it and try to start a new one.

Fava outputs "Starting Fava on ..." instead of "Running Fava on ..."
since [this commit][1].

Also, if the Fava process was already running, `beancount-fava` would
just kill it. Now it will kill it and try to start a new one.

[1]: beancount/fava@8bb3994
@dgchurchill dgchurchill marked this pull request as ready for review September 1, 2024 13:10
@blais
Copy link
Member

blais commented Sep 8, 2024

I don't use Fava but I'll take this one on faith.

@blais blais merged commit 452621f into beancount:main Sep 8, 2024
10 checks passed
@dgchurchill
Copy link
Contributor Author

Thank you

@dgchurchill dgchurchill deleted the fix-launching-fava branch September 17, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants