Revisit API to allow arbitrary keyword arguments to connect() #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnicolodi
force-pushed
the
connect-api
branch
2 times, most recently
from
eaec87b
to
848e29b
Compare
This allows to easily pass arguments that cannot easily be serialized as part of the data source string. In particular this allows to remove some special casing of the beancount data source.
dnicolodi
force-pushed
the
connect-api
branch
from
848e29b
to
1d7d36f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to easily pass arguments that cannot easily be serialized as part of the data source string. In particular this allows to remove some special casing of the beancount data source.