lint

_build_backend.py

@@ -1,4 +1,5 @@
 """Build backend that also compiles translations and frontend."""
+
 # pylint: disable=wildcard-import,function-redefined,unused-wildcard-import
 
 from __future__ import annotations

contrib/pythonanywhere/fava/fava_pythonanywhere_com_wsgi.py

@@ -1,4 +1,5 @@
 """fava wsgi application"""
+
 from __future__ import annotations
 
 from fava.application import create_app

contrib/pythonanywhere/favadev/favadev_pythonanywhere_com_wsgi.py

@@ -1,4 +1,5 @@
 """fava wsgi application"""
+
 from __future__ import annotations
 
 from fava.application import create_app

docs/generate.py

@@ -2,6 +2,7 @@
 
 sphinx-apidoc is not customizeable enough to do this.
 """
+
 from __future__ import annotations
 
 import pkgutil

frontend/src/AutocompleteInput.svelte

@@ -171,8 +171,7 @@
   ul {
     position: absolute;
     z-index: var(--z-index-autocomplete);
-    overflow-x: hidden;
-    overflow-y: auto;
+    overflow: hidden auto;
     background-color: var(--background);
     border: 1px solid var(--border-darker);
     box-shadow: 0 3px 3px var(--border);

pyproject.toml

@@ -121,6 +121,7 @@ filterwarnings = "ignore:.*locked_cached_property.*deprecated:DeprecationWarning
 
 [tool.ruff]
 target-version = "py38"
+preview = true
 line-length = 79
 extend-select = [
     "ALL",
@@ -130,15 +131,18 @@ extend-ignore = [
     "ANN101",   # allow `self` to be untyped
     "ANN401",   # allow `typing.Any`
     "C901",     # ignore mccabe complecity for now
+    "CPY",      # no copyright notices in all files
     "D102",     # allow undocumented methods
     "D105",     # allow magic methods to be undocumented
     "D107",     # allow __init__ to be undocumented - the class should be.
     "DTZ",      # allow naive dates (for now)
+    "E203",     # black
     "EM101",    # allow long strings as error messages
     "EM102",    # allow f-strings as error messages
     "PD",       # pandas-related, has false-positives
     "PERF203",  # allow try-except in loop; zero-cost since Python 3.11
     "PLR2004",  # allow magic constants in comparisons
+    "PLR6301",  # allow methods that do not use self
     "S603",     # This is a bit over-zelous on subprocess.run
     "TRY003",   # allow long string constants as error messages
 ]

src/fava/__init__.py

@@ -1,4 +1,5 @@
 """Fava - A web interface for Beancount."""
+
 from __future__ import annotations
 
 from contextlib import suppress

src/fava/application.py

@@ -9,6 +9,7 @@
     app.run('localhost', 5000)
 
 """
+
 from __future__ import annotations
 
 import logging
@@ -26,7 +27,7 @@
 from urllib.parse import urlparse
 from urllib.parse import urlunparse
 
-import markdown2  # type: ignore[import]
+import markdown2  # type: ignore[import-untyped]
 from beancount import __version__ as beancount_version
 from beancount.utils.text_utils import replace_numbers
 from flask import abort
@@ -38,7 +39,7 @@
 from flask import request
 from flask import send_file
 from flask import url_for as flask_url_for
-from flask_babel import Babel  # type: ignore[import]
+from flask_babel import Babel  # type: ignore[import-untyped]
 from flask_babel import get_translations
 from markupsafe import Markup
 from werkzeug.utils import secure_filename
@@ -130,9 +131,9 @@ def _inject_filters(endpoint: str, values: dict[str, str]) -> None:
         and g.beancount_file_slug is not None
     ):
         values["bfile"] = g.beancount_file_slug
-    if endpoint in ["static", "index"]:
+    if endpoint in {"static", "index"}:
         return
-    for name in ["conversion", "interval", "account", "filter", "time"]:
+    for name in ("conversion", "interval", "account", "filter", "time"):
         if name not in values:
             val = request.args.get(name)
             if val is not None:
@@ -188,7 +189,7 @@ def _setup_filters(
 
     @fava_app.before_request
     def _perform_global_filters() -> None:
-        if request.endpoint in ("json_api.get_changed", "json_api.get_errors"):
+        if request.endpoint in {"json_api.get_changed", "json_api.get_errors"}:
             return
         ledger = getattr(g, "ledger", None)
         if ledger:

src/fava/beans/abc.py

@@ -1,4 +1,5 @@
 """Abstract base classes for Beancount types."""
+
 from __future__ import annotations
 
 from abc import ABC

src/fava/beans/account.py

@@ -1,4 +1,5 @@
 """Account name helpers."""
+
 from __future__ import annotations
 
 from typing import TYPE_CHECKING

src/fava/beans/create.py

@@ -1,6 +1,5 @@
 """Helpers to create entries."""
 
-
 from __future__ import annotations
 
 from decimal import Decimal

src/fava/beans/flags.py

@@ -1,4 +1,5 @@
 """Beancount entry flags."""
+
 from __future__ import annotations
 
 from typing import TYPE_CHECKING

src/fava/beans/funcs.py

@@ -1,4 +1,5 @@
 """Various functions to deal with Beancount data."""
+
 from __future__ import annotations
 
 from typing import Any

src/fava/beans/helpers.py

@@ -1,4 +1,5 @@
 """Helpers for Beancount entries."""
+
 from __future__ import annotations
 
 from typing import Any

src/fava/beans/load.py

@@ -1,4 +1,5 @@
 """Load Beancount files and strings."""
+
 from __future__ import annotations
 
 from typing import TYPE_CHECKING

src/fava/beans/prices.py

@@ -1,4 +1,5 @@
 """Price helpers."""
+
 from __future__ import annotations
 
 import datetime

src/fava/beans/str.py

@@ -1,11 +1,14 @@
 """Convert Beancount types to string."""
+
 from __future__ import annotations
 
 from decimal import Decimal
 from functools import singledispatch
 
 from beancount.core.position import CostSpec
-from beancount.parser.printer import format_entry  # type: ignore[import]
+from beancount.parser.printer import (  # type: ignore[import-untyped]
+    format_entry,
+)
 
 from fava.beans.abc import Amount
 from fava.beans.abc import Cost
@@ -51,8 +54,7 @@ def _(cost: CostSpec) -> str:
         if isinstance(cost.number_per, Decimal):
             amountlist.append(f"{cost.number_per}")
         if isinstance(cost.number_total, Decimal):
-            amountlist.append("#")
-            amountlist.append(f"{cost.number_total}")
+            amountlist.extend(("#", f"{cost.number_total}"))
         if cost.currency:
             amountlist.append(cost.currency)
         strs.append(" ".join(amountlist))

src/fava/beans/types.py

@@ -1,4 +1,5 @@
 """Typing helpers."""
+
 from __future__ import annotations
 
 from typing import TYPE_CHECKING

src/fava/cli.py

@@ -1,4 +1,5 @@
 """The command-line interface for Fava."""
+
 from __future__ import annotations
 
 import errno

src/fava/context.py

@@ -1,4 +1,5 @@
 """Specify types for the flask application context."""
+
 from __future__ import annotations
 
 from typing import TYPE_CHECKING

src/fava/core/__init__.py

@@ -1,4 +1,5 @@
 """This module provides the data required by Fava's reports."""
+
 from __future__ import annotations
 
 from datetime import date

src/fava/core/accounts.py

@@ -1,4 +1,5 @@
 """Account close date and metadata."""
+
 from __future__ import annotations
 
 import datetime

src/fava/core/attributes.py

@@ -1,4 +1,5 @@
 """Attributes for auto-completion."""
+
 from __future__ import annotations
 
 from typing import TYPE_CHECKING

src/fava/core/budgets.py

@@ -1,4 +1,5 @@
 """Parsing and computing budgets."""
+
 from __future__ import annotations
 
 from collections import Counter

src/fava/core/charts.py

@@ -1,4 +1,5 @@
 """Provide data suitable for Fava's charts."""
+
 from __future__ import annotations
 
 from collections import defaultdict

src/fava/core/commodities.py

@@ -1,4 +1,5 @@
 """Attributes for auto-completion."""
+
 from __future__ import annotations
 
 from contextlib import suppress

src/fava/core/conversion.py

@@ -2,6 +2,7 @@
 
 All functions in this module will be automatically added as template filters.
 """
+
 from __future__ import annotations
 
 from typing import TYPE_CHECKING

src/fava/core/documents.py

@@ -1,4 +1,5 @@
 """Document path related helpers."""
+
 from __future__ import annotations
 
 from os import altsep

src/fava/core/extensions.py

@@ -1,4 +1,5 @@
 """Fava extensions."""
+
 from __future__ import annotations
 
 from dataclasses import dataclass
@@ -47,11 +48,7 @@ def load_file(self) -> None:
 
         for cls in all_extensions:
             module = cls.__module__
-            ext_config = (
-                _extension_entries[module]
-                if (module in _extension_entries)
-                else None
-            )
+            ext_config = _extension_entries.get(module, None)
             if cls not in self._loaded_extensions:
                 self._loaded_extensions.add(cls)
                 ext = cls(self.ledger, ext_config)

src/fava/core/fava_options.py

@@ -5,6 +5,7 @@
 parsing the options.
 
 """
+
 from __future__ import annotations
 
 import re

src/fava/core/file.py

@@ -1,4 +1,5 @@
 """Reading/writing Beancount files."""
+
 from __future__ import annotations
 
 import re

src/fava/core/filters.py

@@ -1,4 +1,5 @@
 """Entry filters."""
+
 from __future__ import annotations
 
 import re
@@ -9,9 +10,9 @@
 from typing import Iterable
 from typing import TYPE_CHECKING
 
-import ply.yacc  # type: ignore[import]
+import ply.yacc  # type: ignore[import-untyped]
 from beancount.core import account
-from beancount.ops.summarize import clamp_opt  # type: ignore[import]
+from beancount.ops.summarize import clamp_opt  # type: ignore[import-untyped]
 
 from fava.beans.account import get_entry_accounts
 from fava.helpers import FavaAPIError
@@ -86,7 +87,7 @@ def ANY(self, token: str, _: str) -> tuple[str, str]:  # noqa: N802
         return token, token
 
     def STRING(self, token: str, value: str) -> tuple[str, str]:  # noqa: N802
-        if value[0] in ['"', "'"]:
+        if value[0] in {'"', "'"}:
             return token, value[1:-1]
         return token, value
 

src/fava/core/group_entries.py

@@ -1,4 +1,5 @@
 """Entries grouped by type."""
+
 from __future__ import annotations
 
 from collections import defaultdict

src/fava/core/ingest.py

@@ -1,4 +1,5 @@
 """Ingest helper functions."""
+
 from __future__ import annotations
 
 import datetime
@@ -12,7 +13,7 @@
 from typing import Any
 from typing import TYPE_CHECKING
 
-from beancount.ingest import cache  # type: ignore[import]
+from beancount.ingest import cache  # type: ignore[import-untyped]
 from beancount.ingest import extract
 from beancount.ingest import identify
 

src/fava/core/inventory.py

@@ -1,4 +1,5 @@
 """Alternative implementation of Beancount's Inventory."""
+
 from __future__ import annotations
 
 from decimal import Decimal

src/fava/core/misc.py

@@ -1,4 +1,5 @@
 """Some miscellaneous reports."""
+
 from __future__ import annotations
 
 import datetime

src/fava/core/module_base.py

@@ -1,4 +1,5 @@
 """Base class for the "modules" of FavaLedger."""
+
 from __future__ import annotations
 
 from typing import TYPE_CHECKING

src/fava/core/number.py

@@ -1,4 +1,5 @@
 """Formatting numbers."""
+
 from __future__ import annotations
 
 import copy

src/fava/core/query_shell.py

@@ -1,4 +1,5 @@
 """For using the Beancount shell from Fava."""
+
 from __future__ import annotations
 
 import contextlib
@@ -12,7 +13,7 @@
 from beancount.query.query_compile import CompilationError
 from beancount.query.query_parser import ParseError
 from beancount.query.query_parser import RunCustom
-from beancount.query.shell import BQLShell  # type: ignore[import]
+from beancount.query.shell import BQLShell  # type: ignore[import-untyped]
 from beancount.utils import pager  # type: ignore[attr-defined]
 
 from fava.beans.funcs import execute_query

src/fava/core/tree.py

@@ -1,4 +1,5 @@
 """Account balance trees."""
+
 from __future__ import annotations
 
 from collections import defaultdict

src/fava/core/watcher.py

@@ -1,4 +1,5 @@
 """A simple file and folder watcher."""
+
 from __future__ import annotations
 
 from os import walk