Add instanced rendering #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomrijnbeek
approved these changes
Aug 5, 2024
| private IIndexBuffer? indexBuffer; | ||
| private Func<int>? instanceCount; | ||
|
|
||
| public Builder With(IVertexBuffer buffer) |
There was a problem hiding this comment.
I would probably be more explicit here. With for records replaces, here it appends. This gets especially confusing since the index buffer, which also uses With, indeed does replace. So I would consider calling this AddBuffer (or even AddVertexBuffer) or AppendBuffer.
There was a problem hiding this comment.
I don't disagree. But all the name changes I tried I ended up not being happy with. Perhaps the builder itself isn't quite ideal. I'll leave it like it is for now, and will see if I can come up with a better interface in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What's this?
Allows us to use multiple vertex buffers for renderables, enabling instanced rendering (as well as non-interleaved buffers generally).
🏗 How is it done?
I refactored renderable construction heavily, removing all the separate classes for different cases and just using a single builder and composition. The builder also supports the instanced draw calls now.
The other change that makes instanced rendering possible is adding the
divisorparameter to vertex attributes.💥 Breaking changes
I removed the old renderable construction methods.