Split beesdoo_purchase into sale_suggested_price

[carmenbianca]

According to coopiteasy/vertical-cooperative#204, 'depends on product_main_supplier'

[victor-champonnois]

@robinkeunen @remytms I am wondering wether it should be split to sale_adapt_price_wizard rather than sale_suggested_price. The functionality to split is "- Allows adapting a product's purchase and/or selling price from a PO." What's your opinion ?

[robinkeunen]

I see no wizard in beesdoo_purchase. My suggestion: purchase_order_push_price.

[victor-champonnois]

Looking closely to the code, it's confusing to me because I have the impression it does partly the same thing as sale_suggested_price. Both compute a suggested price. The difference is sale_suggested_price includes taxes :

Obeesdoo/sale_suggested_price/models/product_template.py

Lines 69 to 75 in 44dbb0e

	suggested_price = (
	price
	* uom_factor
	* supplier_taxes_factor
	* sale_taxes_factor
	* profit_margin_factor
	)

Obeesdoo/beesdoo_purchase/models/purchase.py

Lines 72 to 74 in 44dbb0e

	suggested_price = (price * product_tmpl_id.uom_po_id.factor) * (
	1 + product_tmpl_id.categ_id.profit_margin / 100
	)

Should we refactor to use the suggested price from sale_suggested_price ? Or am I wrong to say they are the same ?

[victor-champonnois]

@robinkeunen up :)

[robinkeunen]

@victor-champonnois the difference I see :

• sale_suggested_price computes a ratio between the purchase unit and the selling units
• sale_suggested_price also includes sales and supplier taxes
• button_adapt_price takes the price from the PO rather than the supplier info

I think for consistency and simplicity, it would be good to use the the price of sale_suggested_price as you suggest.

=> add a dependency and compute with calculate_suggested_price(self, price=<new-price-from-po>)

Good catch 👍

[robinkeunen]

@victor-champonnois I also think you should warn Yo from Oufticoop when it's in test so he can take a look.

[victor-champonnois]

This issue caused confusion here https://gestion.coopiteasy.be/web#id=9816&model=project.task&view_type=form&menu_id=