[ADD] beesdoo_shift: next_shift_id on cooperative.status

[robinkeunen]

• add a boolean : worker subscribed before alert date
• add next shift and next shift date to the worker status form

I needed to add shift_shift_ids to res.partner to trigger the computation. I hope it does not impact performance, maybe @tfrancoi knows.

• Question to @remytms : should I make my function depend on today field ?
• I could not write tests for is_subscribed_to_shift computation since the `next_alert_date" is computed in overriding modules.

task

[tfrancoi]

The search should be outside the loop, this kind of code is the root of performance issue
search worker_id in self.mapped('cooperator_id').ids and store the result in a dict
You will send only one query for instead of one for each record.

[robinkeunen]

Ah, thanks. Something like this then ?

    def _compute_next_shift(self):
        now = fields.Datetime.now()
        cooperator_ids = self.mapped("cooperator_id").ids
        # avoid searching for shift in loop
        next_shifts = self.env["beesdoo.shift.shift"].search(
            [("start_time", ">=", now), ("worker_id", "in", cooperator_ids)],
            order="worker_id, start_time",
        )

        next_shift_by_worker = {}
        for shift in next_shifts:
            #  take fist shift for each worker
            if shift.worker_id not in next_shift_by_worker:
                next_shift_by_worker[shift.worker_id] = shift

        for rec in self:
            rec.next_shift_id = next_shift_by_worker[rec.cooperator_id]

Thanks for the review

[victor-champonnois]

FYI Read the code (more for learning than a proper review :) )

[carmenbianca]

Some comments. Looks good overall. Tests are 👌

[remytms]

LGTM