Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] shift: Better logging for generating next planning #513

Open
wants to merge 3 commits into
base: 12.0
Choose a base branch
from

Conversation

carmenbianca
Copy link
Collaborator

@carmenbianca carmenbianca commented May 16, 2023

Description

Odoo task (if applicable)

Timesheet on this task

https://gestion.coopiteasy.be/web#id=10628&model=project.task&view_type=form&menu_id=

Don't timesheet on this task.

https://gestion.coopiteasy.be/web#id=10625&model=project.task&view_type=form&menu_id=

Checklist before approval

  • Tests are present (or not needed).
  • Credits/copyright have been changed correctly.
  • Change log snippet is present.
  • (If a new module) Moving this to OCA has been considered.

Comment on lines 112 to 115
if not planning.task_template_ids:
_logger.error("Could not generate next planning: no task template defined.")
return
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why doesn't this raise an error?

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@codecov-commenter
Copy link

codecov-commenter commented May 17, 2023

Codecov Report

Merging #513 (6286642) into 12.0 (a897570) will increase coverage by 0.00%.
The diff coverage is 66.66%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             12.0     #513   +/-   ##
=======================================
  Coverage   61.64%   61.64%           
=======================================
  Files         193      193           
  Lines        5525     5528    +3     
  Branches      961      961           
=======================================
+ Hits         3406     3408    +2     
- Misses       1976     1977    +1     
  Partials      143      143           
Impacted Files Coverage Δ
shift/models/cooperative_status.py 81.95% <0.00%> (-0.43%) ⬇️
shift/models/planning.py 70.98% <100.00%> (+0.30%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants