[FIX] beesdoo_shift_swap: Prevent a skip of subsequent items #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifying a list while looping over it is not allowed. It causes subsequent items to be skipped. I suspect that this is the cause of a bug where a person who wants to swap a shift is correctly unsubscribed from their old shift, but not subscribed to their new shift. But I have not been able to verify this. It is not clear to me why this code exists. Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
polchampion
approved these changes
Sep 6, 2024
|
@remytms can you review? |
huguesdk
approved these changes
Sep 24, 2024
|
/ocabot merge patch |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
github-grap-bot
added a commit
that referenced
this pull request
Sep 24, 2024
|
@huguesdk your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-534-by-huguesdk-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
huguesdk
requested changes
Sep 24, 2024
There was a problem hiding this comment.
@carmenbianca some tests are failing but i don’t know whether it’s because of the change. would you please check this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modifying a list while looping over it is not allowed. It causes subsequent items to be skipped.
I suspect that this is the cause of a bug where a person who wants to swap a shift is correctly unsubscribed from their old shift, but not subscribed to their new shift. But I have not been able to verify this.
It is not clear to me why this code exists.
Odoo task (if applicable)
T12851
Checklist before approval