Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow AppImage verification when explicitly requested #58

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

rmartin16
Copy link
Member

@rmartin16 rmartin16 commented Oct 24, 2023

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It took me a moment to see why this was "only when explicitly selected", and not just a reversal of the old patch.

This should probably revert the CI config that tests AppImage on this repo as well... but there's a chicken-and-egg problem. CI won't pass until the AppImage template has been updated to downgrade the support package, and the support package won't run CI until this PR is merged. I'll add CI in a followup PR.

@freakboy3742 freakboy3742 merged commit ef67c95 into beeware:main Oct 24, 2023
60 checks passed
@rmartin16 rmartin16 deleted the re-enable-appimage-builds branch October 24, 2023 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants