-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Python 3.13 #49
Conversation
7867efb
to
0d7fe21
Compare
ee9874a
to
abace5e
Compare
See the Briefcase PR for details on the merge strategy for this template change. |
.github/workflows/ci.yml
Outdated
exclude: | ||
# Binary packages aren't available for 3.11+ on Android yet | ||
- backend: "android" | ||
python-version: "3.11" | ||
|
||
- backend: "android" | ||
# Binary packages aren't available for 3.12+ on Android yet | ||
- backend: android | ||
python-version: "3.12" | ||
- backend: android | ||
python-version: "3.13-dev" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do now have 3.12 Android wheels for Pillow and NumPy, so I guess that doesn't need to be excluded.
On 3.13 we don't have wheels for iOS either, so is the plan to exclude iOS as well, or to hold off merging this PR until you've built them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch on the Android 3.12 exclusion; that exists because I originally wrote this PR late last year before 3.12 support landed in Chaquopy.
As for other platforms - we need to exclude binaries on all iOS versions because of the change in binary tag from the 3.13 backport; and we need to exclude numpy and pandas from all platforms on 3.13 specifically because there aren't 3.13 wheels yet. We can drop the "!= iOS" exclusion once I've updated mobile-forge et al and have published new wheels.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we're still missing binary packages on Android for Cryptography on 3.11 and 3.12, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chaquopy issue:
I've reverted the changes related to Android; this PR is now "no worse than it was before" regarding Android support. When wheels for Cryptography on 3.11+ are available, we can push an update to - at this point, we might as well wait until we have full 3.13 support for Android. Binary package support for iOS has also been removed; again, we can restore that in a separate PR once the wheels are available. |
Python 3.13 finalised the "dead batteries" deprecations, so there are some modules that no longer exist.
Temporarily disabling the binary modules so that the 3.13 tests will pass.
This also drops Python 3.8 support, and makes some minor project format changes for recent Briefcase releases.
PR Checklist: