Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the CFBundleIconFile entry #39

Closed
wants to merge 1 commit into from
Closed

Conversation

freakboy3742
Copy link
Member

The CFBundleIconFile entry didn't include the filename extension; as a result, trying to load that file failed.

Refs beeware/toga#2558.

Requires a back port to the 0.3.18 template branch.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@freakboy3742 freakboy3742 requested review from rmartin16 and removed request for rmartin16 May 7, 2024 03:39
@freakboy3742
Copy link
Member Author

Turns out this isn't the fix like I first thought. When Xcode builds the project, the Info.plist file is processed, and no matter how it's passed in, the .icns suffix is stripped. This is because macOS APIs load the icon by asking the bundle for the CFBundleIconFile resource with a file type of .icns, rather than just passing in a full filename for the resource.

@freakboy3742 freakboy3742 deleted the icon-name-fix branch May 7, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant