Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add manifest file #23

Merged
merged 1 commit into from
Oct 29, 2023
Merged

Add manifest file #23

merged 1 commit into from
Oct 29, 2023

Conversation

mhsmith
Copy link
Member

@mhsmith mhsmith commented Oct 29, 2023

This allows Toga to determine the actual Windows version within briefcase run. It already works within briefcase dev, because then it's using the manifest of python.exe.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@mhsmith mhsmith mentioned this pull request Oct 29, 2023
Merged
11 tasks
freakboy3742
freakboy3742 approved these changes Oct 29, 2023
View reviewed changes
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I'll tag a new app build once this has been merged.

@freakboy3742 freakboy3742 merged commit a7d3f2c into beeware:main Oct 29, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhsmith @freakboy3742