Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable pip warnings/checks during requires install #1375

Merged
merged 1 commit into from
Jul 23, 2023

Conversation

rmartin16
Copy link
Member

@rmartin16 rmartin16 commented Jul 22, 2023

Changes

  • Disables some unnecessary (IMO) checks and feedback during app requires installation; specifically:
    • pip version checking
    • pip Python version compatibility

These are all spurious and unnecessary while building the app. I left them for briefcase dev, though, since Briefcase is literally installing in to the user's environment.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@rmartin16 rmartin16 force-pushed the disable-pip-warnings branch 2 times, most recently from 8fcbfcb to a451426 Compare July 22, 2023 16:14
@rmartin16
Copy link
Member Author

rmartin16 commented Jul 22, 2023

hmm....seems pip on debian:bullseye is too old for --root-user-action....

Although, that brings up the fact we're using old versions of pip in the containers. It may be best to have the Dockerfiles update pip...

Briefcase already requires at least pip >= 23.1.1 and --root-user-action was introduced in 22.1.

[edit] removed --root-user-action and implemented this directly in the Dockerfiles

@rmartin16 rmartin16 force-pushed the disable-pip-warnings branch 2 times, most recently from acae537 to df364e0 Compare July 22, 2023 18:39
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@freakboy3742 freakboy3742 merged commit dc4d768 into beeware:main Jul 23, 2023
32 of 35 checks passed
@rmartin16 rmartin16 deleted the disable-pip-warnings branch July 31, 2023 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants