Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support verbose logging for third-party tools #1389

Merged
merged 3 commits into from
Jul 31, 2023

Conversation

rmartin16
Copy link
Member

@rmartin16 rmartin16 commented Jul 28, 2023

Changes

  • Ensure the name of distributable debug APKs have a different file name than release APKs.
  • Verbose tool logging is now enabled with -vv
  • Gradle builds
    • Enable (very verbose) debug logging via --debug
  • linuxdeploy builds
    • Set DEBUG=1 for plugin debug logging
    • Pass -v0 to linuxdeploy for debug logging
  • iOS
    • xcodebuild now runs with -verbose
  • Flatpak
    • Calls to flatpak and flatpak-builder use --verbose
  • macOS Xcode
    • xcodebuild now runs with -verbose
  • Visual Studio
    • Runs MSBuild with -verbosity:detailed

Notes

  • Linux System package builds
    • Evaluated verbose logging for package builds....but there wasn't much value there
  • ADB commands
    • ADB_TRACE=all can increase logging...but it breaks output parsing so omitted
    • If there's potential value here, I can look more deeply at this
  • RCEdit
    • Doesn't seem to support additional logging....not sure if value anyway
  • WiX
    • Verbose logging doesn't seem to add any value...mostly very cryptic messages from light.exe

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@rmartin16 rmartin16 marked this pull request as ready for review July 29, 2023 17:45
@rmartin16
Copy link
Member Author

rmartin16 commented Jul 29, 2023

Adding to its own post to make sure it's clear (and acceptable): as part of the readability refactoring I did for APK/AAB handling, I changed the extension for the Debug APK to be .debug.apk so it doesn't collide with the Release APK extension .apk.

Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I've made one additional tweak, correcting the "count" of verbosity. For some reason, not specifying verbosity returned a count of 1, -v was a count of 2, and -vv was 3. To avoid future confusion, I've made the count match the number of v's.

@freakboy3742 freakboy3742 merged commit 05a0a85 into beeware:main Jul 31, 2023
32 of 35 checks passed
@rmartin16 rmartin16 deleted the debug-tool-logging branch July 31, 2023 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants