Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eagerly update app requirements for DevCommand #1719

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Eagerly update app requirements for DevCommand #1719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/1719.feature.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
The transitive requirements for an app are now eagerly updated when an app's requirements are installed for the ``briefcase dev`` command.
1 change: 1 addition & 0 deletions src/briefcase/commands/dev.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ def install_dev_requirements(self, app: AppConfig, **options):
"-m",
"pip",
"install",
"--upgrade-strategy=eager",
"--upgrade",
]
+ (["-vv"] if self.logger.is_deep_debug else [])
Expand Down
4 changes: 4 additions & 0 deletions tests/commands/dev/test_install_dev_requirements.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ def test_install_requirements_no_error(dev_command, first_app, logging_level):
"-m",
"pip",
"install",
"--upgrade-strategy=eager",
"--upgrade",
]
+ (["-vv"] if logging_level == LogLevel.DEEP_DEBUG else [])
Expand Down Expand Up @@ -58,6 +59,7 @@ def test_install_requirements_error(dev_command, first_app):
"-m",
"pip",
"install",
"--upgrade-strategy=eager",
"--upgrade",
"package-one",
"package_two",
Expand Down Expand Up @@ -93,6 +95,7 @@ def test_install_requirements_test_mode(dev_command, first_app):
"-m",
"pip",
"install",
"--upgrade-strategy=eager",
"--upgrade",
"package-one",
"package_two",
Expand Down Expand Up @@ -121,6 +124,7 @@ def test_only_test_requirements(dev_command, first_app):
"-m",
"pip",
"install",
"--upgrade-strategy=eager",
"--upgrade",
"test-one",
"test_two",
Expand Down
Loading