-
-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add force parameter to create #1870
Conversation
CI isn't running the tests yet because there are failures in the pre-commit and towncrier checks. To find out how to fix these, follow the "Details" links below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The general approach you've taken here makes sense; however:
- You're inconsistent in the use of
force
,auto_overwrite
andauto_overwrite
as a description for this feature in the code. Pick one representation, and stick to it. - Passing tests isn't an "optional, you can fix that for me" part of the contribution process. If you want this PR to be merged, you need to provide a PR that passes tests. We're happy to provide guidance on what tests are required if it's unclear - but in this case, you haven't provided any tests at all, and the existing tests are failing.
Apologies, my changes were not yet complete. I am still working on them. |
perhaps, @freakboy3742, you could provide guidance on how to adapt the tests so that they still capture the way empty (parameter-less) commands have their help generated. Currently, the testing units is using the create method (which is empty before this change) as an empty command for its unit tests. |
Update:
The tests still fail since the create command was used as placeholder. This is something I believe should be addressed as follows:
|
There's another option: promote Unless I'm mistaken, this should simplify most of the test cases you've identified as a problem. |
I'm not going to finish this. If someone wants to pick it up the code is still here. |
Adds a parameter to the
briefcase create
command to skip confirming overwriting existing scaffolds. This makes it easier to test this part of building, such as when debugging new changes to this system, or to investigate problems when people (like myself earlier today) have an issue in their scaffold.The tests do not pass anymore. I looked at them, and I see why, but I would rather leave the decision about how to solve them to you. I hope CI will automatically apply to the PR, otherwise I will paste a log of vox here later.