Ignore vendored .dist-info folders. #1972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmartin16
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
Looks good; small suggestion for changenote but works for me.
Two notes:
- I have a list of scenarios I want to include in some future build-bot system; I'll add packaging the top XXX number of PyPI packages with Briefcase to the list. Should probably just open a proper issue.
- Also, it may be good to annotate these warnings with some kind of explanation...just given that I expect most users may not fully understand everything that is happening and what these messages are trying to communicate.
Co-authored-by: Russell Martin <russell@rjm.li>
Agreed this would be good to thing to verify - if not "top XXX", then at least "packages we know are common and/or problematic".
Yeah - agreed these messages aren't especially clear. Some of them we could possibly even put into an ignore list - .h files, for example, won't be used in a bundled app; and .a files are just taking up space, and can almost certainly be deleted without impact. At the very least, we can improve the message that is output, possibly with a link to a FAQ in the macOS guide about what is going on. |
This was referenced Aug 27, 2024
|
@rmartin16 FYI I've opened #1973 and #1974 to track these two ideas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1970.
setuptools has always included vendored downstream libraries; however, as of 73.0, they started including a vendored copy of the
.dist-infofolder as well. This breaks Briefcase's binary package search mechanism.This PR modifies binary package search to do a shallow search, rather than a deep search.
PR Checklist: