Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scikit-learn recipe #16

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

serhii-vlasiuk
Copy link

@serhii-vlasiuk serhii-vlasiuk commented Nov 13, 2023

Add scikit-learn recipe with version 1.3.1

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@freakboy3742
Copy link
Member

Thanks for the contribution - but I'm unclear how you're getting this to build. It lists scipy as a host dependency... but there's no recipe for scipy. How are you building this requirement?

@serhii-vlasiuk
Copy link
Author

Manually downloaded scikit_learn-1.3.1-cp311-cp311-ios_12_0_iphoneos_arm64.whl
and copy to mobile-forge/dist/ directory.

@freakboy3742
Copy link
Member

freakboy3742 commented Nov 15, 2023

I'm not sure how that's an answer to my question. Scikit-learn is dependent on scipy. If there isn't a scipy recipe, how are you getting a whl file for Scikit-learn?

If that's a typo an you meant to say a scipy wheel... where are you getting that wheel from?

@serhii-vlasiuk
Copy link
Author

I downloaded scipy-1.11.3-cp312-cp312-macosx_12_0_arm64.whl and copy to mobile-forge/dist/ directory

@freakboy3742
Copy link
Member

That can't possibly work. The requirement that is specified is for a host install, so the install will be enforcing iPhone wheel tags (so - ios_12_0_iphonesimulator_arm64, etc). And, in my testing, that's exactly what happens.

[venv3.12-ios_12_0_iphonesimulator_x86_64] Install forge host requirements

Looking in links: /Users/rkm/beeware/mobile-forge/dist
ERROR: Could not find a version that satisfies the requirement scipy==1.11.3 (from versions: none)
ERROR: No matching distribution found for scipy==1.11.3

@serhii-vlasiuk
Copy link
Author

Yes, For iphonesimulator it won't work.

@freakboy3742
Copy link
Member

freakboy3742 commented Nov 20, 2023

Yes, For iphonesimulator it won't work.

Yeah - but it won't work for iphoneos either. If it won't work for iphonesimulator, and it won't work for iphoneos... in what conditions will it work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants