Skip to content

Commit

Permalink
Merge pull request #2475 from freakboy3742/winforms-stacktrace
Browse files Browse the repository at this point in the history
Correct the display of the stack trace dialog on winforms
  • Loading branch information
mhsmith authored Apr 3, 2024
2 parents eb151e8 + 7460662 commit 1b96ca1
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
1 change: 1 addition & 0 deletions changes/2474.bugfix.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
The stack trace dialog no longer raises an async timeout error when displayed.
5 changes: 4 additions & 1 deletion winforms/src/toga_winforms/dialogs.py
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,10 @@ def __init__(self, interface, title, message, content, retry):

self.native.Controls.Add(accept)

self.start_inner_loop(self.native.ShowDialog)
def show():
self.native.ShowDialog()

self.start_inner_loop(show)

def winforms_FormClosing(self, sender, event):
# If the close button is pressed, there won't be a future yet.
Expand Down

0 comments on commit 1b96ca1

Please sign in to comment.