Skip to content

Commit

Permalink
Remove leftover TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
rmartin16 committed Jun 8, 2024
1 parent 8e1170b commit 2f32990
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 4 deletions.
1 change: 0 additions & 1 deletion core/src/toga/sources/list_source.py
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@ def __delattr__(self, attr: str) -> None:
self._source.notify("change", item=self)


# TODO:PR: consider adding supported Protocols...maybe List?
class ListSource(Source):
_data: list[Row]

Expand Down
1 change: 0 additions & 1 deletion core/src/toga/widgets/detailedlist.py
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,6 @@ def __init__(
self._secondary_action = secondary_action
self.on_select = None

# TODO:PR: in reality, _data needs to be Sized and SupportsIndex...
self._data: SourceT | ListSource = None

self._impl = self.factory.DetailedList(interface=self)
Expand Down
1 change: 0 additions & 1 deletion core/src/toga/widgets/mapview.py
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ def subtitle(self, subtitle: str | None) -> None:
self.interface._impl.update_pin(self)


# TODO:PR: __contains__() is required to subclass Set; should it not be added?
class MapPinSet:
def __init__(self, interface: MapView, pins: Iterable[MapPin] | None):
self.interface = interface
Expand Down
1 change: 0 additions & 1 deletion core/src/toga/window.py
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,6 @@ class Dialog(AsyncResult):
RESULT_TYPE = "dialog"

def __init__(self, window: Window, on_result: DialogResultHandler[Any]):
# TODO:PR: should DialogResultHandlerT include the "exception" arg...
super().__init__(on_result=on_result)
self.window = window
self.app = window.app
Expand Down

0 comments on commit 2f32990

Please sign in to comment.