Merge pull request #2291 from freakboy3742/table-crash

Prevent drag operations (and thus crash) on macOS TableView

changes/1156.bugfix.rst

@@ -0,0 +1 @@
+TableViews on macOS will no longer crash if a drag operation is initiated from inside the table.

cocoa/src/toga_cocoa/widgets/table.py

@@ -1,4 +1,4 @@
-from rubicon.objc import SEL, at, objc_method, objc_property
+from rubicon.objc import SEL, NSPoint, at, objc_method, objc_property
 from travertino.size import at_least
 
 import toga
@@ -21,6 +21,16 @@ class TogaTable(NSTableView):
     interface = objc_property(object, weak=True)
     impl = objc_property(object, weak=True)
 
+    # NSTableView methods
+    @objc_method
+    def canDragRowsWithIndexes_atPoint_(
+        self,
+        rowIndexes,
+        mouseDownPoint: NSPoint,
+    ) -> bool:
+        # Disable all drags
+        return False
+
     # TableDataSource methods
     @objc_method
     def numberOfRowsInTableView_(self, table) -> int:
@@ -140,6 +150,7 @@ def create(self):
         )
         self.native_table.usesAlternatingRowBackgroundColors = True
         self.native_table.allowsMultipleSelection = self.interface.multiple_select
+        self.native_table.allowsColumnReordering = False
 
         # Create columns for the table
         self.columns = []

examples/table/table/app.py

@@ -11,7 +11,7 @@ class ExampleTableApp(toga.App):
     lbl_fontsize = None
 
     def load_data(self):
-        yak = toga.Icon.TOGA_ICON
+        yak = toga.Icon.DEFAULT_ICON
         red = toga.Icon("icons/red")
         green = toga.Icon("icons/green")
 

examples/tutorial2/tutorial/app.py

@@ -92,7 +92,7 @@ def startup(self):
             action2,
             text="Action 2",
             tooltip="Perform action 2",
-            icon=toga.Icon.TOGA_ICON,
+            icon=toga.Icon.DEFAULT_ICON,
             group=things,
         )