-
-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Two improvements to cocoa MultilineTextInput: disable richtext, and enable undo #2037
Two improvements to cocoa MultilineTextInput: disable richtext, and enable undo #2037
Conversation
Thanks for the contribution. I'm currently travelling for EuroPython, so finding time for PR reviews is a bit difficult; however, from an initial inspection, this looks good. The only thing obvious improvement I can think of would be a test - this change doesn't decrease code coverage, but it would be good to have some form of validation that pasting rich content or executing an undo has the desired behavior. The complication is that the test will need backend probe implementations for all platforms - however, I think we could probably live with a |
How would such tests fit in? Beyond the dummy backend testing, there's a whole architecture I do not grasp (cocoa/tests_backend, testbed, and what are probes?). I would need some guidance here. |
@bruno-rino As luck would have it, I've just written up an explanation of the testbed architecture for another PR. A cleaned up version of this should probably be in our contribution guide; I've opened #2137 to track this. |
I am writing an undo / redo test for macOS. Which approach would be preferable for triggering the undo / redo action:
|
Cmd-(shift)-Z seems like the better option to me - we're looking to confirm the action as close to "human" interaction as possible. |
So... I guess I should have updated my branch beforehand. |
Replaced with PR #2151 |
I found the current cocoa implementation MultilineTextInput lacking:
PR Checklist: