cocoa: fix default icon search when standalone app is not an .app bundle #2852
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to obtain the default application icon in macOS standalone application by querying
CFBundleIconFile
key, account for possibility that application is not built as an .app bundle. I.e., ensure that the returned string is notNone
before trying to constructpathlib.Path
with it. If returned string isNone
, raiseFileNotFoundError
, which is handled by the calling layer.This fixes
TypeError: argument should be a str or an os.PathLike object where __fspath__ returns a str, not 'NoneType'
error when application has no icon set and PyInstaller is used to build a POSIX executable (as opposed to an .app bundle).PR Checklist: