Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort usings with OrdinalIgnoreCase #1060

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Sort usings with OrdinalIgnoreCase #1060

merged 2 commits into from
Dec 6, 2023

Conversation

loraderon
Copy link
Contributor

@loraderon loraderon commented Dec 5, 2023 •
edited
Loading

Fixes #1061

Newtonsoft.Json should be sorted before NSubstitute

shocklateboy92
shocklateboy92 approved these changes Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@shocklateboy92 shocklateboy92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazed at how many little nuances there are for this. We'll never think up of them all 🦈

Thanks!

@shocklateboy92 shocklateboy92 merged commit 935e36c into belav:main Dec 6, 2023
3 checks passed
@loraderon loraderon deleted the fix/using-case-sort branch December 6, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shocklateboy92 shocklateboy92 shocklateboy92 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

0.26.4 sorts NSubstitute before Newtonsoft.Json
2 participants
@loraderon @shocklateboy92